r4503 - packages/trunk/boswars/debian

[Eddy Petrișor]

On 31/10/2007, Barry deFreese <bddebian-guest at alioth.debian.org> wrote:
> Author: bddebian-guest
> Date: 2007-10-31 04:00:10 +0000 (Wed, 31 Oct 2007)
> New Revision: 4503
>
> Added:
>    packages/trunk/boswars/debian/boswars-data.dirs
>    packages/trunk/boswars/debian/boswars-data.install
>    packages/trunk/boswars/debian/boswars.dirs
>    packages/trunk/boswars/debian/boswars.install
> Modified:
>    packages/trunk/boswars/debian/changelog
>    packages/trunk/boswars/debian/rules
> Log:
> * Remove dh_make comments from rules file
> * New files: debian/ boswars.{dirs,install}, boswars-data.{dirs,install}
> * Call dh_desktop
>

> +++ packages/trunk/boswars/debian/changelog     2007-10-31 04:00:10 UTC (rev 4503)
> @@ -11,5 +11,8 @@
>    [ Barry deFreese ]
>    * New upstream release
>    * Add desktop file
> +  * Remove dh_make comments from rules file
> +  * New files: debian/ boswars.{dirs,install}, boswars-data.{dirs,install}
> +  * Call dh_desktop
>
>   -- Cyril Brulebois <cyril.brulebois at enst-bretagne.fr>  Mon, 13 Aug 2007 14:35:55 +0200

> --- packages/trunk/boswars/debian/rules 2007-10-31 02:24:50 UTC (rev 4502)
> +++ packages/trunk/boswars/debian/rules 2007-10-31 04:00:10 UTC (rev 4503)
> @@ -1,25 +1,11 @@
>  #!/usr/bin/make -f
> -# -*- makefile -*-

^^^^^^^^^^^^^  this should be left there for emacs users

> -# Uncomment this to turn on verbose mode.
> -#export DH_VERBOSE=1

This should be probably left there for easier debugging


> -       # Compile without OpenGL at the moment, see changelog
> -       scons CCFLAGS=$(CCFLAGS) opengl=0
> +       scons CCFLAGS=$(CCFLAGS)

You did not document this change at all. What is this? Why did you do this?
Also, CCFLAGS is not modified to include that option, so it doesn't
seem to be some sort of cleanup.

Will be reverted unless commented until tomorrow (2nd of November) at 18:00pm.


And where is the promised dh_desktop call?


-- 
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein