r4503 - packages/trunk/boswars/debian

Eddy Petrișor eddy.petrisor at gmail.com
Thu Nov 1 14:35:59 UTC 2007


On 01/11/2007, Cyril Brulebois <cyril.brulebois at enst-bretagne.fr> wrote:
> Eddy Petrișor <eddy.petrisor at gmail.com> (01/11/2007):
> > > -# -*- makefile -*-
> >
> > ^^^^^^^^^^^^^  this should be left there for emacs users
>
> No.

I wouldn't care less, is not me using emacs :-D, I was only thinking
in terms of good practice ;-)

> > You did not document this change at all. What is this? Why did you do
> > this?  Also, CCFLAGS is not modified to include that option, so it
> > doesn't seem to be some sort of cleanup.
>
> It needs further investigation since upstream's build sys is scary, and
> on my todo list. I've coordinated with Barry already about further steps
> in boswars' packaging.

So this is actually a revert in itself? In any case, this should have
been documented at least in the svn commit log.

> > Will be reverted unless commented until tomorrow (2nd of November) at
> > 18:00pm.
>
> Please make sure you don't break the further modifications I commited.

Well, as I understand now from this statement, you are taking care of
boswars together with Barry, then is time for me to step down and let
you do the review (I am glad to do this since, like everybody else, I
am already too busy). doubleplusgood :-)

-- 
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein


More information about the Pkg-games-devel mailing list