r4465 - packages/trunk/gravitywars/debian

[Eddy Petrișor]

Barry deFreese wrote:

Note: I will revert the problematic changes unless you answer this mail[*]!

> Add desktop file.  Stop binary from being stripped

> Modified: packages/trunk/gravitywars/debian/rules

> -	-$(MAKE) clean
> +	[ ! -f Makefile ] || $(MAKE) clean

it would be nice to mention in the commit log such changes, too


> -	install -m 755 -s GravityWars101 \
> +	install -m 755 GravityWars101 \

I wonder if when nostrip is *not* provided if this is fixed. Did you test that?

Also, wouldn't using dh_install be a better solution instead of mixing debhelper
stuff with non-debhelper stuff?

>  		`pwd`/debian/gravitywars/usr/games/gravitywars
>  	install -m 644 debian/gravitywars.xpm \
>  		`pwd`/debian/gravitywars/usr/share/games/gravitywars/
> +
> +	# Install desktop file
> +	install -D -m 644 debian/gravitywars.desktop debian/gravitywars/usr/share/applications/gravitywars.desktop
> +

[*] as discussed on the list, we need more review and when comments are not
addressed I will revert them; if the changes are important, explanation shall
follow, if not, the changes will be reverted.

-- 
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20071027/455a4178/attachment.pgp