r4465 - packages/trunk/gravitywars/debian

[Barry deFreese]

*Eddy Petrișor* eddy.petrisor at gmail.com 
<mailto:pkg-games-devel%40lists.alioth.debian.org?Subject=r4465%20-%20packages/trunk/gravitywars/debian&In-Reply-To=E1IlFni-0004Zr-Jh%40alioth.debian.org>
/Sat Oct 27 10:57:24 UTC 2007/

    * Previous message: Bug#360149: Advertising Network
      <http://lists.alioth.debian.org/pipermail/pkg-games-devel/2007-October/005406.html>
    * Next message: Bug#425582: if it is tutti-frutti, then this won't
      be fixed
      <http://lists.alioth.debian.org/pipermail/pkg-games-devel/2007-October/005410.html>
    * *Messages sorted by:* [ date ]
      <http://lists.alioth.debian.org/pipermail/pkg-games-devel/2007-October/date.html#5408>
      [ thread ]
      <http://lists.alioth.debian.org/pipermail/pkg-games-devel/2007-October/thread.html#5408>
      [ subject ]
      <http://lists.alioth.debian.org/pipermail/pkg-games-devel/2007-October/subject.html#5408>
      [ author ]
      <http://lists.alioth.debian.org/pipermail/pkg-games-devel/2007-October/author.html#5408>


------------------------------------------------------------------------

>Barry deFreese wrote:
>
>Note: I will revert the problematic changes unless you answer this mail[*]!
>
>>/ Add desktop file.  Stop binary from being stripped
/>
>>/ Modified: packages/trunk/gravitywars/debian/rules
/>
>>/ -	-$(MAKE) clean
/>>/ +	[ ! -f Makefile ] || $(MAKE) clean
/>
>it would be nice to mention in the commit log such changes, too


Sorry.  To be honest I am never sure how verbose to get in commit logs.


>>/ -	install -m 755 -s GravityWars101 \
/>>/ +	install -m 755 GravityWars101 \
/>
>I wonder if when nostrip is *not* provided if this is fixed. Did you test that?
>

I am pretty sure I did but I will verify.


>Also, wouldn't using dh_install be a better solution instead of mixing debhelper
>stuff with non-debhelper stuff?

Again, I'm never sure how much to go hacking up the packages.  This was how it's already done.


>>/  		`pwd`/debian/gravitywars/usr/games/gravitywars
/>>/  	install -m 644 debian/gravitywars.xpm \
/>>/  		`pwd`/debian/gravitywars/usr/share/games/gravitywars/
/>>/ +
/>>/ +	# Install desktop file
/>>/ +	install -D -m 644 debian/gravitywars.desktop debian/gravitywars/usr/share/applications/gravitywars.desktop
/>>/ +
/>
>[*] as discussed on the list, we need more review and when comments are not
>addressed I will revert them; if the changes are important, explanation shall
>follow, if not, the changes will be reverted.

Fair enough, I just need feedback like this if I am doing things incorrectly.  I wasn't previously subscribed to this list.

>-- 
>Regards,
>EddyP
>=============================================
>"Imagination is more important than knowledge" A.Einstein


Barry deFreese