r4465 - packages/trunk/gravitywars/debian

[Barry deFreese]

Eddy Petrișor wrote:
> Barry deFreese wrote:
>   
>>>> / -	-$(MAKE) clean
>>>>         
>> />>/ +	[ ! -f Makefile ] || $(MAKE) clean
>> />
>>     
>>> it would be nice to mention in the commit log such changes, too
>>>       
>> Sorry.  To be honest I am never sure how verbose to get in commit logs.
>>     
>
> Well, the problem was that this change was not mentioned at all in the commit
> log (although, in all fairness, was mentioned in the debian/changelog).
>
> IIRC there is a tool that allows to commit with the appended changes in
> debian/changelog, so all you have to do is document properly in the changelog
> itself. I think sam is using that, maybe he can help with the name of the utility.
>
>   

I have started copying my changelog entries into the commit log.  If 
there is a util for this, excellent.

>>>> / -	install -m 755 -s GravityWars101 \
>>>>         
>> />>/ +	install -m 755 GravityWars101 \
>> />
>>     
>>> I wonder if when nostrip is *not* provided if this is fixed. Did you test that?
>>>
>>>       
>> I am pretty sure I did but I will verify.
>>     
>
> Please do. I have a gut feeling this is exactly as I suspect.
> When can I expect a result of the test? Is wednesday evening a good deadline[1]?
>
>   
Looks like you can go ahead and revert this.  I get the same result with 
the -s, no -s, and DEB_BUILD_OPTS=nostrip so I'm a little confused at 
this point.

>>> Also, wouldn't using dh_install be a better solution instead of mixing debhelper
>>> stuff with non-debhelper stuff?
>>>       
>> Again, I'm never sure how much to go hacking up the packages.  This was how it's already done.
>>     
>
> Well, nothing stops you from improving this, maybe after a heads-up on the list
> that you intent to do this clean-up? And if nobody objects, go on with the
> change ;-) (/me is taking advantage of your ethusiasm and trying to lure you
> into doing some clean-up work :-D )
>
>   
1.)  Well the feedback loop isn't the greatest but I will try.  2.)  As 
I stated when I joined, I'm happy to do whatever so if we need some 
cleanup work, just point me at them.

<snip>

Thanks,

Barry deFreese