r4492 - in packages/trunk/gtkradiant/debian: . patches

Gerfried Fuchs rhonda at deb.at
Tue Oct 30 06:12:21 UTC 2007


       Hi!

 Sorry to take your commit as example for the first comment, it's not
targetted at you, not a problem with the commit in that part. The second
comment should also be of interest to others, and I think you might have
done it by accident...

* Frits Daalmans <fritsd-guest at alioth.debian.org> [2007-10-30 00:13:02 CET]:
> New Revision: 4492
> 
> Modified:
>    packages/trunk/gtkradiant/debian/changelog
>    packages/trunk/gtkradiant/debian/control
>    packages/trunk/gtkradiant/debian/patches/00list
> Log:
> Fixed GLvoid bug (gcc became stricter?), updated debhelper Build-dep
> 
> 
> -Build-Depends: debhelper (>= 4.0.0), scons (>= 0.96), python (>= 2.3.0), libgtkglext1-dev (>= 1.0.0), libxml2 (>= 2.0.0), libxml2-dev (>= 2.0.0), libgtk2.0-dev (>=2.4.0), libmhash-dev (>= 0.9.0), libpng12-dev (>= 1.2.0), zlib1g-dev (>= 1.2.0), subversion, docbook-to-man, dpatch, sharutils
> +Build-Depends: debhelper (>= 5.0.0), scons (>= 0.96), python (>= 2.3.0), libgtkglext1-dev (>= 1.0.0), libxml2 (>= 2.0.0), libxml2-dev (>= 2.0.0), libgtk2.0-dev (>=2.4.0), libmhash-dev (>= 0.9.0), libpng12-dev (>= 1.2.0), zlib1g-dev (>= 1.2.0), subversion, docbook-to-man, dpatch, sharutils

 Given that dpkg is in the menatime able to parse multiline entries in
the control file properly, and AIUI it does that even in etch, so it
shouldn't raise any problem with backports, but ease reading the diffs
immensly.

 What do I mean with multiline entries? This:

#v+
Build-Depends: debhelper (>= 5.0.0), scons (>= 0.96), python (>= 2.3.0),
  libgtkglext1-dev (>= 1.0.0), libxml2 (>= 2.0.0), libxml2-dev (>= 2.0.0),
  libgtk2.0-dev (>=2.4.0), libmhash-dev (>= 0.9.0), libpng12-dev (>= 1.2.0),
  zlib1g-dev (>= 1.2.0), subversion, docbook-to-man, dpatch, sharutils
#v-

* Frits Daalmans <fritsd-guest at alioth.debian.org> [2007-10-30 00:13:24 CET]:
> New Revision: 4493
> 
> Added:
>    packages/trunk/gtkradiant/debian/patches/52_glvoid.dpatch
> Log:
> patch for include/igl.h

 I guess it was propably a mistake that you've forgotten to add the
patch file right ahead in the same commit, but I've noticed with other
people who seem to do it more regularly. Please commit things that
belong together with a single commit, thanks. I was seriously puzzled
where the patch was when scanning the first commit message.

 So long,
Rhonda



More information about the Pkg-games-devel mailing list