r5614 - in packages/trunk/glest: . debian debian/patches

[Ansgar Burchardt]

Hi,

Eddy Petrișor wrote:
> On 02/02/2008, Ansgar Burchardt <ansgar-guest at alioth.debian.org> wrote:
[Removed files]
> >    packages/trunk/glest/debian/patches/20_be-support-from-kozz.dpatch
> 
> Why did you remove this patch? This patch was not applied.
> Even if is not applied, it can be useful for people interested in
> maintaining it.
I have no problem with including it again, but it won't apply to the new
upstream release (changed location for files, enough changes to not
apply cleanly, ...).

> >    packages/trunk/glest/debian/patches/be-support/
> >    packages/trunk/glest/mk/
> 
> After all these removals, does the package still compiles cleanly two
> times in a row?
The removed patches were not applied.  The upstream mk/ containig the
build system was changed significantly, so the subdirectorys in the
Debian Games SVN are no longer even there.

The package still builds cleanly.
 
> Can you run a debian/rules clean without errors? How about two clean
> commands in a row?
No problem with that.

[Changes to debian/changelog]
> > -  [ Eddy Petrișor ]
> > -  * Removed Homepage: semi-field since the official one exists now
> > -
> 
> Why did you removed this? You must not alter history!
The Homepage: semi-field in the long description was still present when
this changelog entry was added.  Neither r4836 nor r4835 contained
anything related to the Homepage: semi-field.

> >    [ Siegfried-Angel Gevatter Pujals (RainCT) ]
> > -  * New upstream version. Packaging changes:
> > -     - Drop patches/10_fix_gcc-4.1_particle.h.dpatch.
> 
> Same thing here, please do not rewrite history!!!!!
I updated it to say `* Drop patches/10_fix_gcc-4.1_particle.h.dpatch'.
The new upstream version means 2.0.1, not 3.0.0.

> +  [ Ansgar Burchardt ]
> +  * New upstream release (Closes: #463489)
>  dropping patches:
Changed.

> > +  * Use quilt for patch management
> ... instead of dpatch
Changed.

[debian/rules]
> > -include /usr/share/dpatch/dpatch.make
> > +include /usr/share/quilt/quilt.make
> 
> > @@ -38,9 +35,7 @@
> >         dh_testdir
> >
> >         # Add here commands to compile the package.
> > -       cd mk/linux && ln -sf ../../source/glest_game glest_game
> > -       cd mk/linux && ln -sf ../../source/shared_lib shared_lib
> > -       cd mk/linux && jam -q
> > +       jam -q
> >         #docbook-to-man debian/glest.sgml > glest.1
> >
> >         touch build-stamp
> > @@ -52,13 +47,8 @@
> >         rm -f build-stamp configure-stamp
> >
> >         # Add here commands to clean up after the build process.
> > -       cd mk/linux && jam -q clean && cd -
> > +       jam -q distclean
> >
> > -       echo "pwd=`pwd`"
> > -       [ -L mk/linux/glest_game ] && rm -f mk/linux/glest_game || true
> > -       [ -L mk/linux/shared_lib ] && rm -f mk/linux/shared_lib || true
> > -       rm -fr mk/linux/build/*
> > -
> 
> Doesn't removing this leads to unrepresentable changes in the source package?
The upstream build system was changed, so no, it does not.

Regards,
Ansgar

-- 
PGP: 1024D/595FAD19  739E 2D09 0969 BEA9 9797  B055 DDB0 2FF7 595F AD19