Bug#456037: [Fwd: RE: Bug#456037: fenix 0.92 state]

[Javier Serrano Polo]

-------- Missatge reenviat --------
De: Javier Serrano Polo <jasp00 at terra.es>
Per a: Miriam Ruiz <little_miry at yahoo.es>
Assumpte: RE: Bug#456037: fenix 0.92 state
Data: Tue, 18 Dec 2007 15:30:36 +0100

Hi, Miriam.

You may forward this to the BTS if you find it appropriate.

El dj 13 de 12 del 2007 a les 19:15 +0100, en/na Miriam Ruiz va
escriure:
> Exactly which problems are you refering to?

Overall, version 0.84 was much better than 0.92; not the released one,
but the latest 0.84 from CVS. It's too late to go back to an older
version anyway.

You may remember the purpose of #437735 was to avoid segfaults on 64 bit
archs due to implicit pointer conversions. Well, there're segfaults
because of explicit pointer conversions, like this snippet in
fxi/src/sound.c:

        music = Mix_LoadWAV_RW(SDL_RWFromFenixFP(fp),1);
[...]
                return ((int)music);

The quick fix is to restrict to 32 bits. AMD64 people can use ia32-libs
with some additional libraries.
The portable fix is to use a set of resource identifiers. Of course that
means more work for you (ideally, for upstream) but portability's one of
your goals, isn't it? I'm sure you'll figure out the right data
structure.

Have fun.