Bug#485062: fenix: compiler warnings & errors (-Wfoo); pointer/int conversion on 64-bit

[Darren Salt]

Package: fenix
Version: 0.92a.dfsg1-3

While debugging the segfault, I decided to compile with
  -Wformat=2 -Wno-format-zero-length -Wformat-security -Wstrict-aliasing=2
  -Wmissing-format-attribute -Wmissing-noreturn -Wdisabled-optimization
  -Werror-implicit-function-declaration

*Lots* of warnings were produced, mostly to do with conversions between
integer and pointer (this is on amd64), but a few other things too and a few
errors. The attached patches fix the easiest of these.

Upstream needs to fix their pointer storage and casting. At present, they're
throwing away the upper 32 bits, which could cause problems for some. (It
happens to work fine here, but I think that that's down to available memory,
including swap.)

(Due to the pointer/int conversion being unpatched, I've deliberately not
added the "patch" tag to this bug report.)

-- 
| Darren Salt    | linux or ds at              | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| + Output *more* particulate pollutants.      BUFFER AGAINST GLOBAL WARMING.

Stop searching forever. Happiness is unattainable.