Bug#454860: Patch to fix the FTBFS with GCC 4.3: missing #includes

[Cyril Brulebois]

On 20/03/2008, Anibal Avelar wrote:
> I added one patch to fix the FTBFS with GCC 4.3: missing #includes

Well, there are more, see the attached patch, which fixes this FTBFS for
real.

> The bug seems to appear on AMD64 onldy, because on i386 is not
> present.

No, I reproduced the bug on i386.

> Anyway the patch does not affect nothing. Just do you need the
> string.h header inside the file
> moagg-0.18/libMoaggCore/src/LevelReader.cpp.

The correct fix is the use of <cstring> instead.

> Also, do you wish a NMU package if you have lack time?

No thanks. We're rather short of sponsors, instead. I guess Barry (who
already tagged the bug pending, probably because it's fixed in SVN) will
prepare an upload and send an RFS.

>  Regards.

Cheers,

-- 
Cyril Brulebois
-------------- next part --------------
--- a/libMoaggCore/src/LevelReader.cpp
+++ b/libMoaggCore/src/LevelReader.cpp
@@ -1,4 +1,5 @@
 #include <sstream>
+#include <cstring>
 
 #include "Exception.h"
 #include "Configuration.h"
--- a/libMoaggCore/src/System.cpp
+++ b/libMoaggCore/src/System.cpp
@@ -4,6 +4,7 @@
 #include <cerrno>
 #include <sstream>
 #include <list>
+#include <cstring>
 
 #include "Tools.h"
 #include "SyscallException.h"
--- a/libMoaggCore/src/Tools.cpp
+++ b/libMoaggCore/src/Tools.cpp
@@ -2,6 +2,7 @@
 #include <iostream>
 #include <sstream>
 #include <set>
+#include <cstdlib>
 
 #include "Exception.h"
 #include "Tools.h"
--- a/libMoaggGame/src/Tiles.cpp
+++ b/libMoaggGame/src/Tiles.cpp
@@ -2,6 +2,7 @@
 #include <cassert>
 #include <sstream>
 #include <iomanip>
+#include <memory>
 
 
 #include "Configuration.h"
--- a/testsuite/MyAssertionTraits.h
+++ b/testsuite/MyAssertionTraits.h
@@ -2,6 +2,7 @@
 #define MYASSERTIONTRAITS_H
 
 #include <cppunit/TestAssert.h>
+#include <cstring>
 
 CPPUNIT_NS_BEGIN
 
--- a/tools/convertmap.cpp
+++ b/tools/convertmap.cpp
@@ -3,6 +3,7 @@
 #include <memory>
 #include <list>
 #include <cassert>
+#include <cstdlib>
 
 #include "Matrix.h"
 #include "File.h"
--- a/tools/modifymap.cpp
+++ b/tools/modifymap.cpp
@@ -2,6 +2,7 @@
 #include <iostream>
 #include <memory>
 #include <list>
+#include <cstdlib>
 
 #include "Matrix.h"
 #include "File.h"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20080320/3b815a90/attachment.pgp