Bug#416925: oolite: I can confirm this bug

[Henrique de Moraes Holschuh]

Package: oolite
Version: 1.65-6+b1
Followup-For: Bug #416925

I can confirm this bug, I have been bitten by it as well.  Symptoms
are exactly what is described, and to reproduce (once the bug is
active), you just need to load the savegame and try to save it again
(to other filename, for example).

Eventually I managed to get the game to unbork and let me use a
savegame that was thus corrupted, so it might have something to do
with system state (e.g. gettimeofday() output, or some state kept by
X).  Numerous exit/reload ooline cycles were needed, and also a system
reboot (done for other reasons, but it can certainly have helped).

I didn't do much further verification yet, but here are some points:

1. oolite must NEVER verify the conformance of its XML files in
Debian, *UNLESS* you add ALL external entities (such as the DTDs) to
the system catalog and use that.  Otherwise, the box will try to fetch
that over the internet.  This would be unacceptable for various
reasons.

In fact, it would be a good idea to package all DTDs and external
entities used by Oolite and add them properly to the SGML and XML
system catalog.

2. the savegame system needs to be more robust, and fail safely.
Looking at its error unwind paths is advised.

3. Why doesn't the GUI ask for confirmation when you are about to do
something in the F2 menu that will abort the current game?  If it is
corrupted state in-game that causes, e.g., "reset to strict gameplay"
to be activated instead of "save game", that would HELP WONDERS!

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.26.8-t43 (PREEMPT)
Locale: LANG=pt_BR.ISO-8859-1, LC_CTYPE=pt_BR.ISO-8859-1 (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages oolite depends on:
ii  gnustep-base-runtime      1.16.1-2lenny1 GNUstep Base library
ii  libc6                     2.7-16         GNU C Library: Shared libraries
ii  libgcc1                   1:4.3.2-1      GCC support library
ii  libgl1-mesa-glx [libgl1]  7.0.3-6        A free implementation of the OpenG
ii  libglu1-mesa [libglu1]    7.0.3-6        The OpenGL utility library (GLU)
ii  libgnustep-base1.16       1.16.1-2lenny1 GNUstep Base library
ii  libobjc2                  4.3.2-1        Runtime library for GNU Objective-
ii  libsdl-image1.2           1.2.6-3        image loading library for Simple D
ii  libsdl-mixer1.2           1.2.8-4        mixer library for Simple DirectMed
ii  libsdl1.2debian           1.2.13-2       Simple DirectMedia Layer
ii  oolite-data               1.65-2         Data files for the space-sim game 

oolite recommends no packages.

oolite suggests no packages.

-- no debconf information