Bug#532212: openarena: Segfault when deleting non-existent ban address 0

[Guillaume Delacour]

Package: openarena
Version: 0.8.1-4
Severity: -1

When trying to delete a banned address with "bandel" command, i do a mistake and delete address with id 0
(non-existent ban list start from #1) in the built-in console and crash the server:

Starting program: /usr/games/openarena-server +set dedicated 2 +exec server1.cfg
[...]
]listbans  
]banaddr 192.168.0.10
Added ban: 192.168.0.10/32
]listbans            
Ban #1: 192.168.0.10/32
Program received signal SIGSEGV, Segmentation fault.
0xb7e226a3 in memmove () from /lib/i686/cmov/libc.so.6
#0  0xb7e226a3 in memmove () from /lib/i686/cmov/libc.so.6
No symbol table info available.
#1  0x08051230 in SV_DelBanFromList (isexception=<value optimized out>) at code/server/sv_ccmds.c:773

The patch attached correct the problem (do nothing if id to del is lower and equal to 0).

-- System Information:
Debian Release: 5.0.1
  APT prefers stable
  APT policy: (500, 'stable'), (100, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages openarena depends on:
ii  libc6                     2.7-18         GNU C Library: Shared libraries
ii  libcurl3-gnutls           7.18.2-8lenny2 Multi-protocol file transfer libra
ii  libgl1-mesa-glx [libgl1]  7.0.3-7        A free implementation of the OpenG
ii  libogg0                   1.1.3-4        Ogg Bitstream Library
ii  libopenal1                1:1.4.272-2    Software implementation of the Ope
ii  libsdl1.2debian           1.2.13-2       Simple DirectMedia Layer
ii  libspeex1                 1.2~rc1-1      The Speex codec runtime library
ii  libspeexdsp1              1.2~rc1-1      The Speex extended runtime library
ii  libvorbis0a               1.2.0.dfsg-3.1 The Vorbis General Audio Compressi
ii  libvorbisfile3            1.2.0.dfsg-3.1 The Vorbis General Audio Compressi
ii  openarena-data            0.8.1-2        OpenArena game data

openarena recommends no packages.

openarena suggests no packages.

-- no debconf information

*** /tmp/sv_ccmds.c.diff
--- /tmp/sv_ccmds.c	2008-08-09 22:22:37.000000000 +0200
+++ /tmp/openarena-0.8.1/code/server/sv_ccmds.c	2009-06-07 17:40:51.000000000 +0200
@@ -752,7 +752,7 @@
 
 	todel = atoi(Cmd_Argv(1));
 
-	if(todel < 0 || todel > serverBansCount)
+	if(todel <= 0 || todel > serverBansCount)
 		return;
 	
 	for(index = count = 0; index < serverBansCount; index++)