Bug#578444: [bruno at clisp.org: Re: install-reloc error on Debian-hurd and Debian-kfreebsd]

[Sylvain Beucler]

Thanks, I already identified the bug and I think I'll make a new
upstream release.

- Sylvain

----- Forwarded message from Bruno Haible <bruno at clisp.org> -----

Date: Tue, 20 Apr 2010 00:29:29 +0200
From: Bruno Haible <bruno at clisp.org>
To: bug-gnulib at gnu.org
Cc: Sylvain Beucler <beuc at beuc.net>
Subject: Re: install-reloc error on Debian-hurd and Debian-kfreebsd
User-Agent: KMail/1.9.9

Hi Sylvain,

> https://buildd.debian.org/status/package.php?p=freedink
> 
> What happens, apparently, is that 'install-reloc' is called with
> 'RELOC_STRIP_PROG= ' (i.e. == nothing).
> [...]/autotools/install-reloc: 118: : Permission denied
> 
> On line 118 I have:
> test "$strip_prog" = ':' || func_verbose "$strip_prog" "$destprog$exeext" || exit $?
> ($strip_prog comes from earlier strip_prog=$RELOC_STRIP_PROG)

Indeed this empty value of RELOC_STRIP_PROG is the problem. gnulib's NEWS file has
this note:

  2009-01-17  relocatable-prog  In the Makefile.am or Makefile.in, you now also
                              need to set RELOCATABLE_STRIP = :.

This was probably overlooked by some developer. But actually, there is no
need for the maintainer to define this variable, since automake can do it.
I'm applying this followup to
<http://lists.gnu.org/archive/html/bug-gnulib/2009-01/msg00162.html>.


2010-04-19  Bruno Haible  <bruno at clisp.org>

	relocatable: Drop the need to define RELOCATABLE_STRIP in Makefile.am.
	* m4/relocatable.m4 (gl_RELOCATABLE_BODY): Set RELOCATABLE_STRIP.
	Reported by Sylvain Beucler <beuc at beuc.net>.

--- m4/relocatable.m4.orig	Tue Apr 20 00:24:18 2010
+++ m4/relocatable.m4	Tue Apr 20 00:24:14 2010
@@ -1,4 +1,4 @@
-# relocatable.m4 serial 14
+# relocatable.m4 serial 15
 dnl Copyright (C) 2003, 2005-2007, 2009-2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -76,9 +76,15 @@
 
   dnl RELOCATABLE_LIBRARY_PATH can be set in configure.ac. Default is empty.
   AC_SUBST([RELOCATABLE_LIBRARY_PATH])
+
   AC_SUBST([RELOCATABLE_CONFIG_H_DIR])
   AC_SUBST([RELOCATABLE_SRC_DIR])
   AC_SUBST([RELOCATABLE_BUILD_DIR])
+
+  dnl Ensure RELOCATABLE_STRIP is defined in Makefiles (at least those
+  dnl generated by automake), with value ':'.
+  RELOCATABLE_STRIP=':'
+  AC_SUBST([RELOCATABLE_STRIP])
 ])
 
 dnl Determine the platform dependent parameters needed to use relocatability:


----- End forwarded message -----