Bug#555964: wesnoth: Distinguish Random and "Choosing leader"; don't start game with the latter

[Mark de Wever]

tags 555964 + fixed-upstream
thanks

On Sat, Nov 14, 2009 at 09:34:18AM +0100, Mark de Wever wrote:
> > No, not at all what I meant.  When choosing a leader, the player can
> > explicitly choose "Random", no problem.  The bug comes up when the
> > player hasn't *finished* choosing a leader; at that point, from the
> > perspective of the host (and other players who have finished choosing a
> > leader), the player's leader still shows up as "Random" rather than
> > something like "Choosing a leader", and the host can proceed at that
> > point without waiting for the player to finish choosing.  If the host
> > does so, then the player will get to finish choosing a leader, at which
> > point they get thrown directly into the game with a random leader (*not*
> > the one they chose).
> 
> This is indeed the problem, the host doesn't know whether or not the
> player is selecting a leader or already selected a random leader. If the
> host starts the game while the player is still selecting the game is
> started with a random leader for that player. What the player selects at
> that point is ignored since the game has already been started.
> 
> So it's a valid bug, that's why I forwarded it upstream.

Another developer just fixed this issue upstream [1], the fix will be in
Wesnoth 1.7.14.

[1] http://svn.gna.org/viewcvs/wesnoth/?rev=41234&view=rev

-- 
Regards,
Mark de Wever
(Wesnoth developer)