Bug#601859: Can't install package, post-installation script returns -1

[Gerfried Fuchs]

        Hi!

* Ole Laursen <olau at hardworking.dk> [2010-10-30 13:37:09 CEST]:
> Package: wesnoth-1.9-core
> Version: 1:1.9.1-1
> Severity: grave
> 
> Can't install the package, got a big bunch of errors from aptitude
> when I installed wesnoth-1.9, seems to come from the postinst script:
> 
> ole:~/$ LANG=C sudo dpkg --configure wesnoth-1.9-core
> Setting up wesnoth-1.9-core (1:1.9.1-1) ...
> dpkg: error processing wesnoth-1.9-core (--configure):
>  subprocess installed post-installation script returned error exit status 1
> Errors were encountered while processing:
>  wesnoth-1.9-core
> 
> I tried commenting out the divert_oldfiles function in
> wesnoth-1.9-core.postinst and now it works. Maybe the script just
> terminates immediately from the "set -e" at the top if the grep
> commands return 1?

 Ouch, right. Will take a look at it, though given that this is a
development release it's not that high on my agenda - I guess I will get
around to fix it for the next upstream release of 1.9.3, whenever that
might be.

> Another oddity is that the editor script is
> /usr/games/wesnoth-1.9_editor (with underscore) contrary to the other
> scripts that are with hyphen, e.g. wesnoth-1.9-nolog.

 That's because the editor script originally was named wesnoth_editor by
upstream. wesnoth-nolog is a wrapper script that redirects output to
/dev/null. They are historically named that way so I won't change that
part.

> By the way, why is it installing in /usr/games instead of /usr/bin?
> That's weird. Is that a leftover from old Unix structure?

 That's part of the FHS. No games are meant to install into the regular
/usr/bin path so they don't clutter the path for the root account (which
doesn't have /usr/games in its $PATH).

> PS: Thanks for packaging wesnoth, I'm going to have my first try at it
> now. :)

 Please notice that wesnoth-1.9 is the development branch and every
update in that version might potentially be incompatible with the former
version, in case of safegames and similar. If you want to take on a
campaign you are well adviced to install wesnoth-1.8 instead and start
from there.

 Thanks,
Rhonda