Bug#631694: gfpoken: FTBFS with ld --as-needed

[Ilya Barygin]

Package: gfpoken
Version: 0.32-2
Severity: normal
Tags: patch
User: debian-gcc at lists.debian.org
Usertags: ld-as-needed

The package fails to build when --as-needed linker option is enabled,
because of incorrect order of parameters passed to ld. Here's a log of
failed build in Ubuntu:
https://launchpadlibrarian.net/70840199/buildlog_ubuntu-oneiric-i386.gfpoken_0.32-2_FAILEDTOBUILD.txt.gz

See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The attached patch was used in Ubuntu to fix the problem.
https://launchpad.net/ubuntu/+source/gfpoken/0.32-2ubuntu1

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric
  APT policy: (500, 'oneiric')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-10-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
Description: Add libraries to a proper variable. This fixes FTBFS at linking
 with stage with --as-needed option.
Author: Ilya Barygin <barygin at gmail.com>
Bug-Ubuntu: https://launchpad.net/bugs/749253
--- gfpoken-0.32.orig/Makefile.am
+++ gfpoken-0.32/Makefile.am
@@ -27,7 +27,7 @@ gfpoken_CPPFLAGS = -DDATADIR=\"$(pkgdata
 gfpoken_CFLAGS = $(GTK2_CFLAGS)
 # Don't use autoconf substitution here, because it would include
 # implicit dependencies.
-gfpoken_LDFLAGS = -lgtk-x11-2.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lgobject-2.0
+gfpoken_LDADD = -lgtk-x11-2.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lgobject-2.0
 
 gfpoken_SOURCES = \
 	convert.c \