Bug#631702: jumpnbump: FTBFS with ld --as-needed

[Ilya Barygin]

Package: jumpnbump
Version: 1.50+dfsg1-3
Severity: normal
Tags: patch
User: debian-gcc at lists.debian.org
Usertags: ld-as-needed

The package fails to build when --as-needed linker option is enabled,
because of incorrect order of parameters passed to ld. Here's a log of
failed build in Ubuntu:
https://launchpadlibrarian.net/71421640/buildlog_ubuntu-oneiric-i386.jumpnbump_1.50%2Bdfsg1-3_FAILEDTOBUILD.txt.gz

See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The attached patch was used in Ubuntu to fix the problem.
https://launchpad.net/ubuntu/+source/jumpnbump/1.50+dfsg1-3ubuntu1

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric
  APT policy: (500, 'oneiric')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-10-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
Description: Fix order of parameters passed to ld. Fixes FTBFS when linking
 with --as-needed.
Author: Ilya Barygin <barygin at gmail.com>
--- jumpnbump-1.50+dfsg1.orig/Makefile
+++ jumpnbump-1.50+dfsg1/Makefile
@@ -22,7 +22,7 @@ $(MODIFY_TARGET): globals.h
 	cd modify && make
 
 $(TARGET): $(OBJS) $(SDL_TARGET) data globals.h
-	$(CC) -o $(TARGET) $(OBJS) $(LIBS) $(SDL_TARGET)
+	$(CC) -o $(TARGET) $(OBJS) $(SDL_TARGET) $(LIBS)
 
 $(OBJS): globals.h