Bug#617465: Package alex4_1.1-3 failed to build from source on Ubuntu natty

[Peter Pentchev]

On Wed, Mar 09, 2011 at 07:27:10PM +0200, Peter Pentchev wrote:
> On Wed, Mar 09, 2011 at 10:28:56AM +0530, Tarun Kumar Mall wrote:
> > Package: alex4
> > Version: 1.1-3
> > Severity: normal
> > Tags: patch
> > User: ubuntu-devel at lists.ubuntu.com
> > Usertags: origin-ubuntu natty ubuntu-patch
> > 
> > Package failed to build from source.
> > Here is the error log.
> > 
> > Binary package hint: alex4
> > 
> > cc `allegro-config --libs` -laldmb -ldumb -o alex4 actor.o edit.o map.o player.o shooter.o unix.o bullet.o hisc.o options.o script.o timer.o control.o main.o particle.o scroller.o token.o
> [snip lots of linker errors because of badly ordered linker command line]
> > collect2: ld returned 1 exit status
> > make[1]: *** [alex4] Error 1
> > make[1]: Leaving directory `/home/tarun/source/alex4/alex4-1.1/src'
> > make: *** [build-arch-stamp] Error 2
> > dpkg-buildpackage: error: debian/rules build gave error exit status 2
> > debuild: fatal error at line 1335:
> > dpkg-buildpackage -rfakeroot -D -us -uc failed
> > 
> > *** /tmp/tmpdOEglw
> > In Ubuntu, we've applied the attached patch to achieve the following:
> > 
> >   * debian/patches/fix_ftbfs_binutils-gold.patch: changed the order of
> >     libraries in order to fix FTBFS. (LP: #730653) 
> > 
> > We thought you might be interested in doing the same. 
> 
> Tarun, thanka (again - after the same discussion about dma ;) for the bug
> report and the proposed patch!
> 
> Peter, what do you think about the attached series of patches that:
> 
> 1. in the very first patch, fixes this problem (although it does not
>    cause an FTBFS in Debian, it's still a good idea to clean up
>    the code - after all, the Unix linker has been documented to work
>    this way for ages, even though, apparently, GNU ld is a bit lenient)
> 
> 2. in all the rest of the patches, refreshes the alex4 Debian packaging
>    a whole lot - 3.0 (quilt), debhelper 8, Policy 3.9.1,
>    dpkg-buildflags, etc.
> 
> If you have no objections, I could commit those patches to the Debian
> Games Subversion repository; of course, as the principal maintainer of
> alex4, it's your call to like or not like some or all of them :)
> 
> Thanks to both of you for trying to make the world a better place by
> working on Debian and Ubuntu :)

And here's another patch that makes alex4 *not* FTBFS on unstable with
all the warning options that I've turned on and the -Werror that I always
test with :)

G'luck,
Peter

-- 
Peter Pentchev	roam at ringlet.net roam at FreeBSD.org peter at packetscale.com
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
What would this sentence be like if it weren't self-referential?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-Fix-an-undefined-order-of-operations-problem.patch
Type: text/x-diff
Size: 1211 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20110309/89e27e54/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20110309/89e27e54/attachment.pgp>