[RFR] templates://bastet/{bastet.templates}

Christian PERRIER bubulle at debian.org
Mon Mar 28 04:55:43 UTC 2011 

Please find, for review, the debconf templates and packages descriptions for the bastet source package.

This review will last from Monday, March 28, 2011 to Thursday, April 07, 2011.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- bastet.old/debian/bastet.templates	2011-03-17 20:15:27.309656408 +0100
+++ bastet/debian/bastet.templates	2011-03-28 06:39:43.703988723 +0200
@@ -1,18 +1,14 @@
 Template: bastet/score_file_compatibility
-Type: select
-__Choices: keep, remove
-Default: keep
-_Description: What would you like to do with the old scores file?
- It seems that you have got an old-style scores file installed on 
- your system located in '/var/games/bastet.scores'.
+Type: boolean
+Default: true
+_Description: Keep Bastet old scores file?
+ An old-style scores file seems to be left on 
+ this system, in /var/games/bastet.scores.
  .
  As of version 0.43 the scores file format has changed.
- As newer Bastet does not provide any compatibility layer with the
- old format, your old scores file is no longer valid.
+ Bastet does not provide any compatibility layer with the
+ old format and that old scores file is no longer valid.
  .
- To prevent data loss, it's time for you to choose what to do
- with the old file. If you decide to keep it, it's your
- responsibility to keep track of it in the future. 
- If you don't mind losing your old high scores, it's recommended 
- to remove the file to avoid cluttering your system with files 
- not handled by the package manager.
+ You can decide to keep it but no automated conversion process
+ will take place. The file will then no longer be tracked by
+ the package management system.


I completely revamped that template...:-)

First of all, I think that a boolean template perfectly fits the
need. It also avoids the interrogative style, which is discouraged by
lintian (I am responsible for this...) for select templates.

Of course, a small change has to be made in debian/postinst to handle
this:

--- ../bastet.old/debian/postinst       2011-03-17 20:15:27.309656408 +0100
+++ debian/postinst     2011-03-28 06:42:29.320167940 +0200
@@ -8,7 +8,7 @@
 
 deal_with_old_score_file () 
 {
-  if [ "$1" = "remove" ] ; then
+  if [ "$1" = "false" ] ; then
     rm $oldscores
   fi
 }

I also simplified the first paragraph: make it factual and avoid
possessive article ("your"). It's good practice and we use to say in
such case that "this machine might be a corporate server managed by a
junior sysadmin"...though we could wonder why bastet is installed on
it in this case (answer: because the former junior sysadmin as borgin
at work and liked to play bastet).

The second paragraph is also shortened: no real need to be verbose
about data loss and being prepared to handle things later. Just be
affirmative and say that the package management system wil then no
longer deal with the file.

--- bastet.old/debian/control	2011-03-17 20:15:27.309656408 +0100
+++ bastet/debian/control	2011-03-28 06:43:40.029952255 +0200
@@ -13,8 +13,8 @@
 Package: bastet
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: Free clone of Tetris, featuring a bastard level
- Bastet (stands for "bastard Tetris") is a free (GPL'd) clone of Tetris(r) 
+Description: clone of Tetris, featuring a bastard level
+ Bastet (which stands for "bastard Tetris") is a free clone of Tetris(r) 
  which is designed to be "as bastard as possible": it tries to compute how 
  useful blocks are and gives you the worst, the most bastard it can find. 
  Playing bastet can be a painful experience, especially if you usually 

We know it's free: otherwise, it wouldn't be in the Debian main
archive..:-)

"GPL'd" is mentioned anyway in debian/copyright.

-- 


-------------- next part --------------
Template: bastet/score_file_compatibility
Type: boolean
Default: true
_Description: Keep Bastet old scores file?
 An old-style scores file seems to be left on 
 this system, in /var/games/bastet.scores.
 .
 As of version 0.43 the scores file format has changed.
 Bastet does not provide any compatibility layer with the
 old format and that old scores file is no longer valid.
 .
 You can decide to keep it but no automated conversion process
 will take place. The file will then no longer be tracked by
 the package management system.
-------------- next part --------------
--- bastet.old/debian/bastet.templates	2011-03-17 20:15:27.309656408 +0100
+++ bastet/debian/bastet.templates	2011-03-28 06:39:43.703988723 +0200
@@ -1,18 +1,14 @@
 Template: bastet/score_file_compatibility
-Type: select
-__Choices: keep, remove
-Default: keep
-_Description: What would you like to do with the old scores file?
- It seems that you have got an old-style scores file installed on 
- your system located in '/var/games/bastet.scores'.
+Type: boolean
+Default: true
+_Description: Keep Bastet old scores file?
+ An old-style scores file seems to be left on 
+ this system, in /var/games/bastet.scores.
  .
  As of version 0.43 the scores file format has changed.
- As newer Bastet does not provide any compatibility layer with the
- old format, your old scores file is no longer valid.
+ Bastet does not provide any compatibility layer with the
+ old format and that old scores file is no longer valid.
  .
- To prevent data loss, it's time for you to choose what to do
- with the old file. If you decide to keep it, it's your
- responsibility to keep track of it in the future. 
- If you don't mind losing your old high scores, it's recommended 
- to remove the file to avoid cluttering your system with files 
- not handled by the package manager.
+ You can decide to keep it but no automated conversion process
+ will take place. The file will then no longer be tracked by
+ the package management system.
--- bastet.old/debian/control	2011-03-17 20:15:27.309656408 +0100
+++ bastet/debian/control	2011-03-28 06:43:40.029952255 +0200
@@ -13,8 +13,8 @@
 Package: bastet
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: Free clone of Tetris, featuring a bastard level
- Bastet (stands for "bastard Tetris") is a free (GPL'd) clone of Tetris(r) 
+Description: clone of Tetris, featuring a bastard level
+ Bastet (which stands for "bastard Tetris") is a free clone of Tetris(r) 
  which is designed to be "as bastard as possible": it tries to compute how 
  useful blocks are and gives you the worst, the most bastard it can find. 
  Playing bastet can be a painful experience, especially if you usually 
-------------- next part --------------
Source: bastet
Section: games
Priority: optional
Maintainer: Debian Games Team <pkg-games-devel at lists.alioth.debian.org>
Uploaders: Nacho Barrientos Arias <nacho at debian.org>
Build-Depends: debhelper (>= 8), libncurses5-dev | libncurses-dev, libboost1.42-dev,
               libboost-program-options1.42-dev, po-debconf
Standards-Version: 3.9.1
Homepage: http://fph.altervista.org/prog/bastet.shtml
Vcs-Svn: svn://svn.debian.org/svn/pkg-games/packages/trunk/bastet/
Vcs-Browser: http://svn.debian.org/wsvn/pkg-games/packages/trunk/bastet/?op=log

Package: bastet
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: clone of Tetris, featuring a bastard level
 Bastet (which stands for "bastard Tetris") is a free clone of Tetris(r) 
 which is designed to be "as bastard as possible": it tries to compute how 
 useful blocks are and gives you the worst, the most bastard it can find. 
 Playing bastet can be a painful experience, especially if you usually 
 make "canyons" and wait for the long I-shaped block.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20110328/2b55d392/attachment.pgp>

More information about the Pkg-games-devel mailing list