Bug#628166: viruskiller: do not start

[Bill Allombert]

On Sat, Sep 03, 2011 at 10:16:47PM +0200, Ansgar Burchardt wrote:
> Hi,
> 
> Bill Allombert <ballombe at debian.org> writes:
> > viruskiller does not start (on both i386 and amd64):
> [...]
> > Made 10,000 unsuccessful attempts to grab 4 inactives directories!!
> 
> This looks like LP# 502978 [1].  Could you check that you have several
> files and directories in your $HOME?

Hello Ansgar, I have 55 directories and 609 files in $HOME, but maxDirectories=2.
It seems the issue is the hard-coded 50 in 

bool Directory::addFile(GameObject *file)
{
        if (realFileCount == 50)
                return false;

in src/CDirectory.cpp.

The following command only report a single directory on my system:
ls --sort=none -F ~ | head -n 50 |grep -e '/$'
so addFile will only find a single directory in $HOME, while it need at least 4.

I would suggest that viruskiller provide a dummy file hierarchy in
/usr/share/games/viruskiller/ that is used by -safemode,
and that it defaults to safemode when it cannot find filename in
$HOME. Using /tmp is not safe enough.

> [1] <https://bugs.launchpad.net/ubuntu/+source/viruskiller/+bug/502978>

This launchpad bug does not provide much information to the submitter to
track the problem, unfortunately. I had no idea that viruskiller used filename
from $HOME since it did not start.

Cheers,
-- 
Bill. <ballombe at debian.org>

Imagine a large red swirl here.