Bug#696562: Barrage: Name field too short

Dr. David Alan Gilbert dave at treblig.org
Sat Dec 22 21:38:55 UTC 2012


Package: barrage
Version: 1.0.3-1

This was originally Ubuntu bug report :
https://bugs.launchpad.net/ubuntu/+source/barrage/+bug/1008011

When built with fortify this fails at the code, menu.c:38

        snprintf( entry->name, 24, "%s", name ); entry->name[23] = 0;

which all looks nice and careful until you look at menu.h:

typedef struct {                                                                                                                                                                                                                                                               
        char    name[20];       /* name */                                                                                                                                                                                                                                     
        int     x, w, h;        /* size and x position; y depends on the position                                                                                                                                                                                              
                                   in the menu and is computed dynamically */                                                                                                                                                                                                  
        int     id;             /* unique id */                                                                                                                                                                                                                                
} MenuEntry;                                                                                                                                                                                                                                                                   

Here is a patch I wrote:
https://launchpadlibrarian.net/126521626/03_fixmenuentrylength.patch

Actually, I've just ntocied it's fixed upstream in 1.0.4 so probably
the best thing is just to grab that.

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\ gro.gilbert @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/



More information about the Pkg-games-devel mailing list