Fwd: Mame 0.145 and the sorry state of included libraries !

[Emmanuel Kasper]

Am 2012-02-28 12:34, schrieb Cesare Falco:
> Hey Manu and all!
> 
>> I have now a working patch to build with libjpeg, but I am not sure of
> I've just improved it to allow switch between system/custom library.
> This should make it acceptable upstream too, after Marcelo's has been rejected
> http://forums.bannister.org/ubbthreads.php?ubb=showflat&Number=77683#Post77683
> 
> Ehm... who's Marcelo anyway? I see his patch looks just the same as
> that in the debian/patches tree :)

I am that Marcello :)

> 
>> the code quality. Maybe someone can review it ? Generally is there some
>> kind of code review tools/people available inside Debian ?
> Looks good to me but I have no idea regarding Debian coding...
> 
>> I mean it is better to fine embedded libs with system libs, but if it
>> lowers the code quality ...
> I agree, and also have to correct my former assumption that a 7zip
> system library is available which is ...ehr... not!
> 
>> Note that with this patch Mame does not build anymore on Debian/Stable
>> since it requires libjpeg8.
> ...or you can use the new BUILD_JPEGLIB switch to use the custom lib... ;)
I have seen it
http://anonscm.debian.org/gitweb/?p=pkg-games/mame.git;a=commitdiff;h=5d3ebe9543b1d994d0a9cac55aee5b35b80006f3

Clean commit, nice job, go on !

When we have a working patch for libjpeg + libflac we can submit it
again, it mame devs refuse it at least it might be of some interests to
other Unix/linux packagers.

Manu