Bug#678543: openarena-server: Does not remove pid file on server crash

[Markus Koschany]

Package: openarena-server
Version: 0.8.8-4
Severity: normal
Tags: patch

Hello,

the openarena server does not remove its pid file when the server
crashes. I experience this issue in conjunction with bug #664637.
Unfortunately the server fails to start again (for example if i use
monit to solve this issue) because the init-script detects a pid file
and terminates with error code 2 thus nothing happens. 

Could you consider to replace 

 if [ -f $PIDFILE ]; then
         return 2

in /etc/init.d/openarena-server with

start-stop-daemon --start --quiet --pidfile $PIDFILE \
 --background --exec $BINARY --startas $DAEMON \
 --make-pidfile --chuid $USER \
 -- $DAEMON_OPTS > /dev/null 2>&1 || return 2

or something similar?  

Kind regards
Markus Koschany



-- System Information:
Debian Release: 6.0.5
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.24 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages openarena-server depends on:
ii  adduser                   3.112+nmu2     add and remove users and groups
ii  ioquake3-server           1.36+svn2224-3 Standalone server for ioQuake3 bas
ii  libc6                     2.11.3-3       Embedded GNU C Library: Shared lib
ii  openarena-081-maps        0.8.5split-2   OpenArena game data - maps from 0.
ii  openarena-081-misc        0.8.5split-2   OpenArena game data - miscellaneou
ii  openarena-081-players     0.8.5split-2   OpenArena game data - player graph
ii  openarena-081-players-mat 0.8.5split-2   OpenArena game data - "mature" pla
ii  openarena-081-textures    0.8.5split-2   OpenArena game data - textures fro
ii  openarena-085-data        0.8.5split-2   OpenArena game data - 0.8.5 update
ii  openarena-088-data        0.8.8-1        OpenArena game data
ii  openarena-data            0.8.5-3        OpenArena game data

openarena-server recommends no packages.

openarena-server suggests no packages.

Versions of packages ioquake3-server depends on:
ii  libc6                   2.11.3-3         Embedded GNU C Library: Shared lib
ii  zlib1g                  1:1.2.3.4.dfsg-3 compression library - runtime

-- Configuration Files:
/etc/default/openarena-server changed [not included]
/etc/openarena-server/server.cfg changed [not included]

-- no debconf information