Bug#673087: RFS: the-powder-toy/78.1-1 [ITP] -- Physics sandbox game

[Benoît Knecht]

Hi Aditya,

Aditya Vaidya wrote:
>   I am looking for a sponsor for my package "the-powder-toy"
> * Package name    : the-powder-toy
>   Version         : 78.1-1
>   Upstream Author : HardWIRED and respective owners
> * URL             : http://powdertoy.co.uk/
> 
> 
> * License         : GPL-3
>   Section         : games
> 
>   It builds those binary packages:
> 
>     the-powder-toy - Physics sandbox game
> 
>   To access further information about this package, please visit the
> following URL:
> 
>   http://mentors.debian.net/package/the-powder-toy

I wanted to review your package, so I tried building it from the git
repository mentioned in debian/control [1] using

  git checkout upstream
  git checkout pristine-tar
  git checkout master
  git-buildpackage --git-pristine-tar --git-pbuilder

but it failed with

  fatal: Path 'the-powder-toy_81.0.orig.tar.bz2.delta' does not exist in 'refs/heads/pristine-tar'
  pristine-tar: git show refs/heads/pristine-tar:the-powder-toy_81.0.orig.tar.bz2.delta failed
  gbp:error: Couldn't checkout "the-powder-toy_81.0.orig.tar.bz2": /usr/bin/pristine-tar returned 128

[1] git://github.com/kroq-gar78/The-Powder-Toy_deb.git

It also looks like this repository was intended for the ubuntu package,
so it probably shouldn't be mentioned in the debian/control file of the
debian package.

The version you linked to in this request [2] compiles and runs fine,
but lintian reports a bunch of issues:

  W: the-powder-toy source: unknown-field-in-dsc original-maintainer
  I: the-powder-toy source: debian-watch-file-is-missing
  I: the-powder-toy: spelling-error-in-binary usr/lib/games/the-powder-toy/powder targetted targeted
  W: the-powder-toy: hardening-no-fortify-functions usr/lib/games/the-powder-toy/powder
  W: the-powder-toy: hardening-no-relro usr/lib/games/the-powder-toy/powder
  P: the-powder-toy: no-upstream-changelog
  I: the-powder-toy: unknown-field-in-control original-maintainer
  E: the-powder-toy: menu-icon-not-in-xpm-format usr/share/pixmaps/powdertoy-48.png
  P: the-powder-toy: maintainer-script-without-set-e postrm
  P: the-powder-toy: maintainer-script-without-set-e postinst

[2] http://mentors.debian.net/debian/pool/main/t/the-powder-toy/the-powder-toy_78.1-1.dsc

Since you've obviously kept working on the package, I thought I'd ask
you if you wanted to submit a more current version before I go into a
deeper review.

Cheers,

-- 
Benoît Knecht