Bug#673128: /etc/init.d/openarena-server: init-script-disabled-by-upgrade does not work

[Stepan Golosunov]

Package: openarena-server
Version: 0.8.8-3
Severity: normal
Tags: patch
File: /etc/init.d/openarena-server

openarena-server was disabled by upgrade and yet it was running (at
least, after reboot).

% ps -AF|grep '[i]oq3'
% sudo /etc/init.d/openarena-server start
[ ok ] Starting OpenArena dedicated server: openarena-server (disabled during upgrade, not starting - see /usr/share/doc/openarena-server/NEWS.Debian.gz).
% ps -AF|grep '[i]oq3'                   
106      26809     1 13 41069 10316   0 14:40 ?        00:00:00 /usr/lib/ioquake3 ioq3ded +set com_basegame baseoa +set fs_basepath /usr/lib/openarena-server +set com_homepath .openarena +set com_legacyprotocol 71 +set com_protocol 71 +set sv_master1 dpmaster.deathmask.net +set cl_motd 0 +exec debian_server.cfg


The relevant fragment of /etc/init.d/openarena-server is missing
a return statement in this case: 


--- /etc/init.d/openarena-server.orig	2012-04-02 01:04:36.000000000 +0400
+++ /etc/init.d/openarena-server	2012-05-16 14:55:49.688354738 +0400
@@ -32,10 +32,11 @@
         return 2
     fi
     if [ "$START_DAEMON" = "unless-disabled-by-upgrade" ]; then
         if [ -e /var/games/openarena-server/init-script-disabled-by-upgrade ]; then
             echo -n " (disabled during upgrade, not starting - see /usr/share/doc/openarena-server/NEWS.Debian.gz)"
+            return 0
         fi
     elif [ "$START_DAEMON" != 1 ]; then
         echo -n " (disabled in /etc/default/openarena-server - deprecated, see /usr/share/doc/openarena-server/README.Debian.gz)"
         return 0
     fi



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (900, 'testing'), (400, 'stable')
Architecture: i386 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages openarena-server depends on:
ii  adduser                       3.113+nmu1
ii  ioquake3-server               1.36+svn2224-3
ii  libc6                         2.13-32
ii  openarena-081-maps            0.8.5split-2
ii  openarena-081-misc            0.8.5split-2
ii  openarena-081-players         0.8.5split-2
ii  openarena-081-players-mature  0.8.5split-2
ii  openarena-081-textures        0.8.5split-2
ii  openarena-085-data            0.8.5split-2
ii  openarena-088-data            0.8.8-1
ii  openarena-data                0.8.5split-2

openarena-server recommends no packages.

openarena-server suggests no packages.

-- no debconf information