Bug#701355: sdl-ball: ftbfs with GCC-4.8

[Matthias Klose]

Package: src:sdl-ball
Version: 1.01-3
Severity: important
Tags: sid jessie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-4.8

The package fails to build in a test rebuild on at least amd64 with
gcc-4.8/g++-4.8, but succeeds to build with gcc-4.7/g++-4.7. The
severity of this report may be raised before the jessie release.

  main.cpp:1423:76: error: stray ',' at end of member declaration

The full build log can be found at:
http://people.debian.org/~doko/logs-20130217/gcc48/sdl-ball_1.01-3_unstable_gcc48.log
The last lines of the build log are at the end of this report.

To build with GCC 4.8, either set CC=gcc-4.8 CXX=g++-4.8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t experimental install g++ g++-4.7 g++-4.8 libc6-dev

The test rebuild was done with eglibc-2.17 and GCC-4.8, so some issues
might be caused by the updated glibc.

[...]
SCHROOT_SESSION_ID=unstable-amd64-sbuild-397c31ec-4fc9-4a12-b197-f16f92cd1f99
SCHROOT_UID=1000
SCHROOT_USER=user
SHELL=/bin/sh
USER=user

dpkg-buildpackage
─────────────────

dpkg-buildpackage: source package sdl-ball
dpkg-buildpackage: source version 1.01-3
dpkg-buildpackage: source changed by Evgeni Golov <evgeni at debian.org>
 dpkg-source --before-build sdl-ball-1.01
dpkg-buildpackage: host architecture amd64
 fakeroot debian/rules clean
dh clean
   dh_testdir
   dh_auto_clean
make[1]: Entering directory `/«PKGBUILDDIR»'
rm -f *.o sdl-ball
make[1]: Leaving directory `/«PKGBUILDDIR»'
   dh_clean
 debian/rules build-arch
dh build-arch
   dh_testdir -a
   dh_auto_configure -a
   dh_auto_build -a
make[1]: Entering directory `/«PKGBUILDDIR»'
g++ -DDATADIR="\"/usr/share/games/sdl-ball/\"" -c -Wall `sdl-config --cflags` main.cpp -o main.o
main.cpp:1423:76: error: stray ',' at end of member declaration
     GLfloat x[100], y[100], r[100], g[100], b[100], a[100],s[100], cr,cg,cb,;
                                                                            ^
main.cpp: In function 'bool screenShot()':
main.cpp:3687:42: warning: narrowing conversion of '(setting.settings::resx % 256)' from 'int' to 'unsigned char' inside { } is ill-formed in C++11 [-Wnarrowing]
   unsigned char header[6] = {setting.resx%256,setting.resx/256,setting.resy%256,setting.resy/256,24,0};
                                          ^
main.cpp:3687:59: warning: narrowing conversion of '(setting.settings::resx / 256)' from 'int' to 'unsigned char' inside { } is ill-formed in C++11 [-Wnarrowing]
   unsigned char header[6] = {setting.resx%256,setting.resx/256,setting.resy%256,setting.resy/256,24,0};
                                                           ^
main.cpp:3687:76: warning: narrowing conversion of '(setting.settings::resy % 256)' from 'int' to 'unsigned char' inside { } is ill-formed in C++11 [-Wnarrowing]
   unsigned char header[6] = {setting.resx%256,setting.resx/256,setting.resy%256,setting.resy/256,24,0};
                                                                            ^
main.cpp:3687:93: warning: narrowing conversion of '(setting.settings::resy / 256)' from 'int' to 'unsigned char' inside { } is ill-formed in C++11 [-Wnarrowing]
   unsigned char header[6] = {setting.resx%256,setting.resx/256,setting.resy%256,setting.resy/256,24,0};
                                                                                             ^
make[1]: *** [main.o] Error 1
make[1]: Leaving directory `/«PKGBUILDDIR»'
dh_auto_build: make -j1 returned exit code 2
make: *** [build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2