Bug#719496: freeorion: input textfields doesn't work after a while.

[Javier Cantero]

El Sun, Oct 06, 2013 at 12:58:12PM +0200, Markus Koschany dice:
> Thanks for your offer. If you find out what option or program causes
> this behaviour on Xfce and interferes with Freeorion, respectively OIS,
> please let me know.

Definitely it's a libOIS related issue. There are several messages in
the libois forums with the same symptoms, for example this:
http://www.wreckedgames.com/forum/index.php/topic,5851.0.html

I've got a way to go around it, applying one of the pending pull
requests from
https://github.com/wgois/Object-oriented-Input-System--OIS-/pulls ).
But before that, let me say that the libOIS version packaged in Debian
testing and the version in the FreeOrion sources are not exactly the
same. The debian version is based in the 1.3.0 stable (with some
additional fixes), but FO uses the actual HEAD of SourceForge (r40 in
http://sourceforge.net/p/wgois/code/40/log/ or master branch of GitHub.

So the first thing I made was to patch libois-1.3.0 package with the
changes of the FreeOrion version. Since the most of them are W32 stuff,
and the non-linux related source files are removed from debian source
package, I only had to patch this:

  https://gist.github.com/javiercantero/7628876

With this patch the behaviour of FO didn't change, but at least we have
the same source base to compare. Then I tried to merge this pull
request:

  https://github.com/wgois/Object-oriented-Input-System--OIS-/pull/3

The change is trivial, it only deletes the XNextEvent() call next to
XPeekEvent() in _isKeyRepeat() method of LinuxKeyboard class. You can
get the patch from the pull request, or cloning the k1ll's repository
v(x11_key_repeat_fix branch). But for simplicity, I also put the exact
patch I applied here:

  https://gist.github.com/javiercantero/7629235

With this small change FreeOrion input texts are working fine. The
OISInput.cfg sets x11_keyboard_grab=false (and x11_mouse_grab=false). I
can change the window focus, and the keyboard comes with me. When I
return to FO, the keyboard also returns, and everything seems fine.
Except Alt-TAB. If I do an Alt-TAB switch and return to FO, the keyboard
doesn't return.

Although this patch works, even me can see that this is a dirty hack,
hard to say why it works, or what it fixes. At least I can't. That is
why I'm going to test another two patches to see what it does.
Specifically the OIS version of worldforge project has some promising
changes I'd like to test: https://github.com/worldforge/ois 

I'm going to post this in the FO forum thread, to see what they think
about it.

Any comments are welcome.

-- 
                       Saludos de Javier <jcantero at escomposlinux.org>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 917 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20131124/16dbf469/attachment.sig>