Bug#739486: game-data-packager: Please add support for Tyrian data using following patch.

[Simon McVittie]

On 29/12/14 07:19, Alexandre Detiste wrote:
> my patch still applies automatically.

Thanks, I'll merge it. Here is a review; I'll probably fix some of this
myself.

You're mixing hard tabs (U+0009) and 4-space units for indentation.
Please be consistent within each file, and consider configuring your
editor to display hard tabs.

+	if [ "$CHECKSUM" != "$ZIPSUM" ]; then
+		echo "warning: checksum is not what we expected" >&2
+	fi

Is there any reason why you would want to continue with incorrect data,
or more than one version of tyrian21.zip floating around? I would prefer
this to be a fatal error.

Does Tyrian have a non-shareware version? If it does, I would prefer to
treat it like Quake 1 and produce tyrian-registered-data (or
tyrian-full-data or just tyrian-data) for the full game, or
tyrian-shareware-data or something for the shareware version.

+    for file in $files; do
+        slipstream_file "$file" "usr/share/games/tyrian/$file"
+    done

This will do all the work of repacking the .deb once for each of the
50ish files you're adding to it. It would be better to unpack it once
(or, perhaps preferably, just ship the necessary files unpacked like
quake2 does), then copy in all the files, then finally pack it up.

    S