Bug#751362: springlobby: Please update to wxwidgets3.0

[Olly Betts]

On Thu, Jun 12, 2014 at 10:26:46AM +0200, Markus Koschany wrote:
> On 12.06.2014 07:23, Olly Betts wrote:
> > We're aiming to migrate the archive to using wxwidgets3.0 instead of
> > wxwidgets2.8, and intend to drop wxwidgets2.8 before jessie is released.
> 
> back then I was not sure if the wxwidgets3.0 transition is really going
> to happen before the freeze.

I'm increasingly confident it will (though there is still wxpython to
deal with).

> You can easily verify this by compiling springlobby with wxwidgets3.0.
> Then start the application and go to Edit->Preferences. The result is an
> assertion which I had reported upstream.
> 
> https://github.com/springlobby/springlobby/issues/235

That's one I've seen a few times before with other applications -
they've now committed a fix, which is exactly what I would have
suggested.

FWIW, most of the "assertion failed" messages are things which are just
as much of an issue (or not) in wx2.8.  The difference is that wx3.0
defaults to enabling "WXDEBUG" checks for incorrect API usage.  In wx2.8
you had to rebuild wx with non-default options (or in Debian, install
the libwxgtk2.8-dbg package) and then rebuild your app.  Without the
assertions on, wx quietly tries to handle such cases (typically by just
returning from the method in question).

These assertions can be disabled by defined NDEBUG when building the
application - e.g. by adding -DNDEBUG to CPPFLAGS - which means such
assertions will be handled as they would have been by a default build of
2.8.

So it's generally good to try to fix them, but if the app worked OK
with wx2.8, just disabling them isn't an unreasonable solution.

> There are more issues
> 
> https://github.com/springlobby/springlobby/issues/234

The listbox not scrolling with the mousewheel sounds like this, which
was fixed in Debian in 3.0.0-3:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736374

> > At this point in the transition (and in the jessie release cycle), I'd
> > definitely recommend that packages stick with wxwidgets3.0 and we work
> > on resolving any issues.  That way there's a good chance to actually
> > resolve them before the jessie freeze.
> 
> I am not sure if we can do a better job than upstream here but I am open
> for any suggestions.

I suspect they have less experience with migrating things to wxwidgets3.0
than I have now amassed.  I'm certainly OK with trying to help where I
can.

Cheers,
    Olly