Bug#748204: Function declaration without parameter type list shadows risk of stack underflow

[Michael Tautschnig]

Package: phlipple
Version: 0.8.5-1
Severity: wishlist
Usertags: goto-cc

During an analysis of all packages using our research compiler tool-chain (using
tools from the cbmc package) the following error was found:

The declaration of OS_stopMusic in osinterface.h

http://sources.debian.net/src/phlipple/0.8.5-1/src/osinterface.h?hl=37#L37

shadows the fact that OS_stopMusic actually requires an argument:

http://sources.debian.net/src/phlipple/0.8.5-1/src/osinterface_sdl.c?hl=414#L414

Yet none is provided with any of the calls to this function.

As, however, the argument isn't used code might execute correctly at present. To
avoid the risk of undefined behaviour the definition of OS_stopMusic should be
fixed.

Best,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20140515/cda347a2/attachment.sig>