Bug#748393: #define MAXSPECIALCROSS with different values

[Michael Tautschnig]

Package: chocolate-doom
Version: 2.0.0-1
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
gcc -I../textscreen -I../opl -I../pcsound  -O2 -g -Wall -Wdeclaration-after-statement -Wredundant-decls -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -Wl,-z,relro -L/usr/lib/x86_64-linux-gnu -lSDL -o chocolate-doom i_main.o i_system.o m_argv.o m_misc.o d_event.o d_iwad.o d_loop.o d_mode.o deh_str.o i_cdmus.o i_endoom.o i_joystick.o i_scale.o i_sound.o i_timer.o i_video.o i_videohr.o m_bbox.o m_cheat.o m_config.o m_controls.o m_fixed.o sha1.o memio.o tables.o v_video.o w_checksum.o w_main.o w_wad.o w_file.o w_file_stdc.o w_file_posix.o w_file_win32.o z_zone.o w_merge.o gusconf.o i_pcsound.o i_sdlsound.o i_sdlmusic.o i_oplmusic.o midifile.o mus2mid.o aes_prng.o net_client.o net_common.o net_dedicated.o net_gui.o net_io.o net_loop.o net_packet.o net_query.o net_sdl.o net_server.o net_structrw.o deh_io.o deh_main.o deh_mapping.o deh_text.o doom/libdoom.a ../textscreen/libtextscreen.a ../pcsound/libpcsound.a ../opl/libopl.a -Wl,-z,relro -L/usr/lib/x86_64-linux-gnu -lSDL -L/usr/lib/x86_64-linux-gnu -lSDL -lSDL_mixer -lSDL_net -lm -lsamplerate 

file p_map.c line 104: error: conflicting array sizes for variable "spechit"
old definition in module p_enemy file p_enemy.c line 270
struct line_s *[8l]
new definition in module p_map file p_map.c line 104
struct line_s *[20l]
make[4]: *** [chocolate-doom] Error 64
make[4]: Leaving directory `/srv/jenkins-slave/workspace/sid-goto-cc-chocolate-doom/chocolate-doom-2.0.0/src'
make[3]: *** [all-recursive] Error 1

This conflict is caused by MAXSPECIALCROSS taking different values across
different files:

http://sources.debian.net/src/chocolate-doom/2.0.0-2/src/doom/p_enemy.c?hl=268,270#L268
http://sources.debian.net/src/chocolate-doom/2.0.0-2/src/doom/p_map.c?hl=101,104#L101

While at least the actual storage takes the larger value, various
inconsistencies may result.

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20140516/11e4dadb/attachment-0001.sig>