Bug#748090: libsdl-mixer1.2: leaks lots of memory with fluidsynth, rendering system unresponsive

[beuc at debian.org]

Control: retitle -1 libsdl-mixer1.2: leaks lots of memory with fluidsynth, rendering system unresponsive
Control: reassign -1 libsdl-mixer1.2
Control: found -1 1.2.12-11+b1

Hi SDL_Mixer maintainers,

I got a report of memory leak in the FreeDink package, which only
happens when using the fluidsynth backend for SDL_Mixer (which
apparently is now default).

I don't know if this bug comes from SDL_Mixer or in Fluidsynth itself,
so I'm forwarding it an upstream-step above :)

Ben: would you be so kind as to provide your saved game and some more
instructions on how to reproduce the problem?

Cheers!
Sylvain

On Wed, May 14, 2014 at 12:41:58AM -0700, Ben Longbons wrote:
> Package: freedink-engine
> Version: 1.08.20120427-2.1+b1
> Severity: important
> 
> Dear Maintainer,
> 
> After running freedink for a while, it allocates several gigabytes of
> memory, which makes the system unresponsive due to lots of swapping.
> 
> The problem is particularly noticable in the Edge of the World when
> walking between the church and the dangerous parts to the left.
> 
> It leaks over 100 MB each time.
> 
> valgrind gives a bunch of different backtraces from libfluidsynth.so,
> but they all come from the same part of freedink:
> 
> ==11711==    by 0x4E3FE72: Mix_LoadMUS (in /usr/lib/x86_64-linux-gnu/libSDL_mixer-1.2.so.0.12.0)
> ==11711==    by 0x404CAD: PlayMidi (bgm.c:218)
> ==11711==    by 0x404F78: check_midi (bgm.c:312)
> ==11711==    by 0x4168CB: load_map (dinkvar.c:1014)
> 
> -- System Information:
> Debian Release: jessie/sid
>   APT prefers testing
>   APT policy: (600, 'testing'), (500, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages freedink-engine depends on:
> ii  freedink-data    1.08.20111016-1
> ii  freepats         20060219-1
> ii  libc6            2.18-5
> ii  libfontconfig1   2.11.0-5
> ii  libfreetype6     2.5.2-1
> ii  libsdl-gfx1.2-5  2.0.25-4
> ii  libsdl-image1.2  1.2.12-5+b2
> ii  libsdl-mixer1.2  1.2.12-11+b1
> ii  libsdl-ttf2.0-0  2.0.11-3
> ii  libsdl1.2debian  1.2.15-9
> ii  ttf-liberation   1.07.4-1
> 
> Versions of packages freedink-engine recommends:
> ii  freedink-dfarc  3.10-1.1
> 
> freedink-engine suggests no packages.
> 
> -- no debconf information
> 

On Wed, May 14, 2014 at 11:44:33AM +0200, beuc at debian.org wrote:
> Can you check if you have the same behavior with the traditional
> TiMidity backend?
> 
> I think you can force it with:
> SDL_FORCE_SOUNDFONTS=1 freedink ...
> 
> You should hear a noticeable difference in the music - and possibly a
> difference in matter of RAM usage ;)
> 
> If no leak, this means the leak comes from the new fluidsynth backend
> in libsdl-mixer.

On Fri, May 16, 2014 at 11:12:52AM +0200, beuc at debian.org wrote:
> On Thu, May 15, 2014 at 09:56:59PM -0700, Ben Longbons wrote:
> > On Wed, May 14, 2014 at 2:44 AM,  <beuc at debian.org> wrote:
> > > SDL_FORCE_SOUNDFONTS=1
> > 
> > There is no leak with that in the environment.
> 
> Thanks for checking.
> 
> Would you mind retitling&reassigning the bug to libsdl-mixer or
> libfluidsynth?
> 
> Cheers!
> Sylvain