Bug#727781: zsnes: Fatal error when loading state (DSP-1 ROM)

[Etienne Millon]

* Jason Pleau <jason at jpleau.ca> [141111 22:34]:
> Hello !
> 
> I've been trying to find a way to fix this issue as well for a few days now.
> 
> I managed to get it to work with this following changes (see attached file)
> 
> The rename of usr/bin/zsnesd => usr/bin/zsnes could probably be handled
> better (maybe with dh_links ?), for now as long as I can load my game
> states I'm happy :)
> 
> Thoughts on this patch? I'm not sure how adding --enable-debug fixes
> this, so it could very well lead to other issues.

Hi,

Thanks indeed for work! It's indeed the -O0 that fixes the issue in
that case. It's also possible to disable hardening while keeping
optimizations.

I didn't publish my patch when I worked on this last year, but here it
is.

It's tempting to apply the following hunk to continue the job and
eliminate the last copy_func call:

> -    copy_func(&buffer, &Op02FX, 11*4+3*4+28*8);
> +    COPY_SHORT(Op02FX);
> +    COPY_SHORT(Op02FY);
> +    COPY_SHORT(Op02FZ);
> +    COPY_SHORT(Op02LFE);
> +    COPY_SHORT(Op02LES);
> +    COPY_SHORT(Op02AAS);
> +    COPY_SHORT(Op02AZS);

but unfortunately it makes it crash again and I'm not sure I
understand why (especially one year later).

-- 
Etienne Millon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fortify-source-dsp1.patch
Type: text/x-diff
Size: 5404 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20141117/cc10709f/attachment-0001.patch>