Bug#771300: vcmibuilder should not be case sensitive

[Johannes Schauer]

Control: forwarded -1 https://github.com/vcmi/vcmi/pull/63

Hi Dave,

On Fri, 28 Nov 2014 12:21:00 +0100 Dave <dave at pennvad.eu> wrote:
> vcmibuilder is case-sensistive, while you can’t expect some strict case
> scheme from HoMM3 data.

I agree. This should be fixed.

> An example here where all data is available but vcmibuilder miss it due to case sensitivity:
> dave at HAL9000:~$ ls /usr/local/share/games/heroes-of-might-and-magic-3/
> binkw32.dll              goggame.sdb   h3camped.exe  h3update.txt            heroes3_tutorial.pdf  readmesd.txt
> data                     h3blade.cnt   h3camped.hlp  heroes3_ab_manual.pdf   ifc21.dll             readme.txt
> eula                     h3blade.exe   h3ccmped.cnt  heroes3.cnt             maps                  smackw32.dll
> games                    h3blade.hlp   h3ccmped.exe  heroes3.exe             mcp.dll               webcache.zip
> gameuxinstallhelper.dll  h3bmaped.cnt  h3ccmped.hlp  heroes3.hlp             mp3
> goggame-1207658787.dll   h3bmaped.exe  h3maped.cnt   heroes3_manual.pdf      mp3dec.asi
> goggame-1207658787.ico   h3bmaped.hlp  h3maped.exe   heroes3_refcard.pdf     mss32.dll
> goggame-1207658787.info  h3camped.cnt  h3maped.hlp   heroes3_sod_manual.pdf  readmeab.txt
> dave at HAL9000:~$ LANGUAGE=C vcmibuilder --data /usr/local/share/games/heroes-of-might-and-magic-3/
> cp: cannot stat ‘/usr/local/share/games/heroes-of-might-and-magic-3//Data’: No such file or directory
> cp: cannot stat ‘/usr/local/share/games/heroes-of-might-and-magic-3//Maps’: No such file or directory
> cp: cannot stat ‘/usr/local/share/games/heroes-of-might-and-magic-3//Mp3’: No such file or directory
> 
> The problem can be seen with GOG installer version 2.1.0.20, that includes the directory "mp3" while vcmibuilder looks for "Mp3":
> dave at HAL9000:~$ LANGUAGE=C vcmibuilder --gog setup_homm3_complete_french_2.1.0.20.exe 
> cp: cannot stat ‘/home/dave/.local/share/vcmi/buildertmp/app/Mp3’: No such file or directory

I cannot reproduce your problem because the only version of the homm3_complete
installer from the gog website that I can see is version 2.0.0.16.

Nevertheless, wherever your version comes from, this should be fixed and the
fix is not hard:

https://github.com/vcmi/vcmi/pull/63

> Tagged as "important" as it breaks vcmibuilder with some version(s?) of GOG
> installer, fell free to set down the severity if you think it is not a
> "breaking bug".

It doesn't matter now because we're in freeze and vcmi will not migrate to
testing anyways.

Thanks!

cheers, josch