Review mrrescue

[Tobias Frost]

tags: moreinfo

Hi Steve,

here's a review:

- In your ITP, #707691, you write "Package source uploaded to pkg-games
git." but d/control has no VCS-* fields.

- there are lots of trailing spaces in d/copyright, wrap-and-sort(1)
should sort that.

- d/copyright is incomplete. just one example: mrrescue/AnAL.lua is
copyright 2009-2010 Bart Bes 
The website also says: All source code for
Mr. Rescue with the exception of the modules slam, AnAL and TSerial, is
licensed under the zlib license. Check the LICENSE file for more info.

Worse, TSerial does not specify a license and the only somehow relating 
homepage [1] I could find does not either. Please contact upstream / author
of TSerial for clearifcation. (email on [1])
PS: I just saw you did already... Please share the response with me and it the email
to d/copyright as a Comment. 

d/mrrescue.1
the manpage is still section 1, not 6
the options section needs some tweaking: mrrsecue doesn't take args itself, but the script passes them 
to love(1). However, love(1) does not take args... So maybe this section should go? 
(Can you please explain why you pass the args to love?)

I would write as the short explanation "2d arcarde action game" instead of "platformer built in love",
as the latter gives no inportant information for the end user.

d/rules
please don't override targets when not really needed.
- remove mrresuce.love via d/clean
- at least here, there is no build_dir after build, a stripped down d/control works here. 

Please fix the above and give me a ping when ready. Please don't forget to send also a copy of the
license-email.

 
[1] https://love2d.org/wiki/Tserial


--
tobi