Bug#782624: Hard-codes "firefox"

[Trent W. Buck]

Package: scorched3d
Version: 43.2a.dfsg-6.1
Severity: minor

Clicking on "Help" doesn't do anything for me,
because I don't have "firefox" in my path:

    root at tough:~# cat ~p678/.xsession-errors
    [...]
    sh: 1: firefox: not found

    twb at frey[scorched3d-43.2a.dfsg]$ grep -r firefox
    src/common/common/DefinesScorched.cpp:  std::string buffer = S3D::formatStringBuffer("firefox %s", url.c_str());

This should

  1. probably refer to sensible-browser.
  2. use execvp (or similar), not system().
     (Ref. http://cwe.mitre.org/top25/#CWE-78)

Due to (1), the debian/control may need
Recommends: sensible-utils --
I don't remember what the current rules are for that.


-- System Information:
Debian Release: 8.0
Architecture: amd64 (x86_64)

Kernel: Linux 3.14-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash