Found fix for rrootage patch #9 (09_rrootage_make_highres_default.patch)

[Markus Koschany]

[CC to pkg-games-devel, I send the original e-mail to Ivy]


Hello Ivy,

Am 11.12.2015 um 21:31 schrieb Ivy Foster:
> Hey, folks,
> 
> Thanks for your work packaging rrootage! I discovered today why the patch
> 09_rrootage_make_highres_default.patch doesn't apply: another patch (I
> presume) changed a line near the actually patched line. The following
> change allows the patch to apply successfully (and the next line of sed
> updates the manual).
> 
> 	sed 's/windowMode = 0/windowMode = 1/' \
> 		-i debian/patches/09_rrootage_make_highres_default.patch
> 
> 	sed -e '/^Medium resolution mode/ s/ (default)//' \
> 		-e '/^High resolution mode/ s/\.$/ (default)./' \
> 		-i debian/rrootage.6
> 
> Share & enjoy!
> 
> Ivy

Thank you very much for bringing this to our attention. The
09_rrootage_make_highres_default.patch was never applied because someone
disabled the patch in the debian/patches/series file for unknown
reasons. I have rebased the patch according to your instructions.

> 
> P.S.: Any chance of someone with better C skills than my measly ones
> patching this thing to drop its state into
> ${XDG_DATA_HOME:-$HOME/.local/share}/rrootage/
> instead of directly into $HOME?

If you mean the ~/.rr.prf file, the path is defined in
src/attractmanager.c. We could simply change the current value to
/.local/share/rrootage/rr.prf which is indeed a better place. I will
make the necessary changes with the next upload of rrootage.

P.S.:

It is better to file bug reports for such issues because they won't get
lost which can sometimes happen if you send a message to our bug mailing
list directly. Here is a short introduction about the bug tracking system.

https://wiki.debian.org/HowtoUseBTS

You can also contact us at debian-devel-games at lists.debian.org which is
mainly used for discussions about Debian and games.

Cheers,

Markus






-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20151212/986ac876/attachment.sig>