Found fix for rrootage patch #9 (09_rrootage_make_highres_default.patch)

[Markus Koschany]

Am 12.12.2015 um 19:17 schrieb Ivy Foster:
> On 12 Dec 2015, at  5:44 pm +0100, Markus Koschany wrote:
>> Hello Ivy,
> 
> Hello,
> 
>> Am 11.12.2015 um 21:31 schrieb Ivy Foster:
> 
[...]
> I'm willing to bet that the fact it failed to apply was the reason (-: .
> 
>> I have rebased the patch according to your instructions.
> 
> Thanks.
> 
>>> P.S.: Any chance of someone with better C skills than my measly ones
>>> patching this thing to drop its state into
>>> ${XDG_DATA_HOME:-$HOME/.local/share}/rrootage/
>>> instead of directly into $HOME?
> 
>> If you mean the ~/.rr.prf file, the path is defined in
>> src/attractmanager.c. We could simply change the current value to
>> /.local/share/rrootage/rr.prf which is indeed a better place. I will
>> make the necessary changes with the next upload of rrootage.
> 
> Well, the reason I didn't do it myself is that $XDG_DATA_HOME is,
> of course, a variable, so you have to do some fiddling to check
> whether the user's set it, and if so respect it, and if not default to
> ~/.local/share. Hardcoding ~/.local/share messes things up when people
> change the var. In shell or scheme or haskell, I know how to do that
> stuff; my C's just not good enough for me to do it quickly and without
> much consultation of manuals.

Unfortunately I don't know how to properly check for $XDG_DATA_HOME in C
without reading the documentation and some manuals first either. Though
I don't think there is much harm if we hardcode the directory to
$HOME/.local/share/rrootage because that is the default for
XDG_DATA_HOME on Debian systems. Only a tiny minority of people will
ever want to change that. I believe the benefit is greater than the
risks because rr.prf is a binary file that nobody really cares about. If
the game can use it and it is out of the way, that would be good enough.

But if you disagree with this change, I suggest to keep the current
state until someone else finds a better solution. That would be a
wishlist bug against rrootage by the way. :)

Cheers,

Markus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20151212/265bbac2/attachment.sig>