Bug#776280: g-d-p: please add support for No Rest For The Living

[Fabian Greffrath]

Hi Alexandre,

Am Freitag, den 06.02.2015, 12:26 +0100 schrieb Alexandre Detiste: 
> I've added support for "No Rest For The Living" in my tree,
> using checksums found here: http://doom.wikia.com/wiki/NERVE.WAD,
> but I don"t own the game, so I can't test it.

thanks for doing that. The checksums on doomwiki.org (doom.wikia.com is
obsolete!) should be right. Anyway, here are mine:

$ cksum nerve.wad 
2480614527 3819855 nerve.wad
$ md5sum nerve.wad 
967d5ae23daf45196212ae1b605da3b0  nerve.wad
$ sha1sum nerve.wad 
3451288383fb16e196f273d9f85d58c1fda97bf4  nerve.wad
$ sha256sum nerve.wad 
2d234de8700ee403375fda278e50ea17739b36703b3316e0429b05aca4458fa9
nerve.wad

> Can you give it a try ?
> https://github.com/a-detiste/game-data-packager/commits/master
> (2 last commits)

I have to admit, I haven't followed g-d-p development that closely, i.e.
I have checked singly commits and made my comments, but I haven't tried
out the application and its new features at all lately. However, after
checking out your repository and building and installing the package, it
doesn't seem to work at all anymore:

$ game-data-packager doom2
Traceback (most recent call last):
  File "/usr/lib/python3.4/runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.4/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/share/games/game-data-packager/game_data_packager/__main__.py", line 21, in <module>
    run_command_line()
  File "/usr/share/games/game-data-packager/game_data_packager/__init__.py", line 2407, in run_command_line
    game.run_command_line(parsed)
  File "/usr/share/games/game-data-packager/game_data_packager/__init__.py", line 1933, in run_command_line
    destination=destination)
  File "/usr/share/games/game-data-packager/game_data_packager/__init__.py", line 2136, in build_packages
    deb = self.build_deb(package, destination, compress=compress)
  File "/usr/share/games/game-data-packager/game_data_packager/__init__.py", line 2200, in build_deb
    if not self.fill_dest_dir(package, destdir):
  File "/usr/share/games/game-data-packager/game_data_packager/__init__.py", line 1637, in fill_dest_dir
    self.modify_control_template(control, package, destdir)
  File "/usr/share/games/game-data-packager/game_data_packager/games/doom_common.py", line 102, in modify_control_template
    destdir)
  File "/usr/share/games/game-data-packager/game_data_packager/__init__.py", line 1722, in modify_control_template
    'An expansion will inherit the engine of the full game'
AssertionError: An expansion will inherit the engine of the full game


Maybe I should mention that I have installed the entire Doom canon
in /usr/share/games/doom, including every official IWAD and PWAD for all
games and even including duplicates (e.g. from the BFG Edition, the XBOX
edition or the Playstation Network) in subdirectories. Maybe that is too
confusing fot g-d-p, I have no idea?

Sorry I couldn't hepl you. :/

- Fabian