Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG

[Alexandre Detiste]

Le lundi 9 février 2015, 13:24:28 Simon McVittie a écrit :
> On 09/02/15 11:43, Alexandre Detiste wrote:
> > Le lundi 9 février 2015, 11:25:11 Simon McVittie a écrit :
> >> I would rather have new games consistently install their data to the
> >> default location (/usr/share/games/PACKAGENAME)
> > 
> > I agree, but this "-data" in package name sounds completely extraneous,
> > why not use "/usr/share/games/PACKAGENAME".rstrip('-data') instead as default ?
> 
> rstrip doesn't work like you think it does, but I get the general idea.

Ok, I've squashed a now commit on top of this one, and removed the erroneous
comment about Quake3. I've tested if with Tyrian and RTCW.

> I used PACKAGENAME instead of (PACKAGENAME with any trailing -data
> removed) because when you're making an essentially arbitrary design
> choice, I think there's value in choosing the option that is easiest to
> document.

If we follow the rules of least surprise, and just do what all the free games 
in the archive do; we don't even need to document it thoroughly .

We could have make-template write it as a comment in generated yaml file;
and/or have an heuristic that when source path is from /usr/local/ ... 
it puts it into "repack from" instead of an "install to".

> However, I do see your point, and removing -data by default
> would also be OK (but please do not break existing games).

quake3-data already has an explicit install_to: , but it was
a the end of the record and I didn't noticed it.
I don't know about the two Jedi games, I guess you'd need to patch the
default path in the engines.
 
> Adding .desktop files and icons for Doom WADs and ScummVM/ResidualVM
> games does stretch that rule, because .desktop files can have bugs (e.g.
> lack of Keywords, or a low-quality icon).
So we should contact these teams and ask if there would be ok to do it;
or provide a game-data-packager-data or game-data-packager-runtime
with those... then the generated games would depend on this new package.

> low-quality icon
I tried to extract Grimfandango icon from the .exe with wrestool & icoutil;
but the result is quite deceptive.

> I would be tempted to put the
> .desktop files in ScummVM and ResidualVM, with a TryExec pointing to a
> dummy executable in the relevant -data package, although for ScummVM
> that does get into difficult issues of "should these be in contrib?"
It would be a bit too much pedantic to push scummvm in contrib because
it includes .desktop files to non-free games...

> I don't think we necessarily want a contrib equivalent of src:quake just
> for the .desktop files.
...and replacement icons.