Bug#737137: game-data-packager: patch to support hexdd

[Simon McVittie]

On Thu, 30 Jan 2014 at 15:04:18 +0000, Johey Shmit wrote:
> included is a patch to support the hexen addon 'hexdd.wad'.

I have added support for hexdd.wad in git (as "hexen-deathkings-data"
following the newer $GAME(-$QUALIFIER)-data naming scheme).

I have not added support for Strife, Hacx, or any version of Chex Quest,
so I haven't marked this bug pending (yet).

I added support for hexen-demo-data but it's currently commented out,
because it doesn't work on Chocolate Doom. At some point I'll try it
with Doomsday.

On Thu, 30 Jan 2014 at 18:24:05 +0100, Fabian Greffrath wrote:
> Am Donnerstag, den 30.01.2014, 15:04 +0000 schrieb Johey Shmit: 
> > This patch also changes the installation folder of heretic and hexen wads
> > back to /usr/share/games/hexen|heretic as it was before version 30. I originally
> > suggested the change to put all doom engine files into /usr/share/games/doom
> > but I now think that was not such a good idea.
> 
> Please keep it that way!
> 
> Currently all Doom engines in Debian that also support playing Heretic
> or Hexen have /u/s/games/doom set as their IWAD directory.

I'm a little confused about what the right thing is here. The installation
folder has in fact been /usr/share/games/(hexen|heretic) since v35,
possibly accidentally. I can change it back to /usr/share/games/doom
if necessary - it's easy to do now.

On Fri, 31 Jan 2014 at 15:12:59 +0000, Johey Shmit wrote:
> Attached is a patch against git that adds support
> for the following games:
> 
> - heretic shareware
> - hexen shareware
> - strife shareware
> - hexen add on hexdd
> - strife registered

To put this into the new packaging scheme for g-d-p, I would like the
following for each wad file, and for each file that gets downloaded
or unpacked while deriving the downloadable ones:

* canonical filename
* some sort of version identification, if there are others with the same
  canonical filename (e.g. the various flavours of doom.wad documented
  on the Doom wiki)
* exact size (e.g. cksum $files)
* md5 (md5sum $files)
* sha1 (sha1sum $files)
* sha256 (sha256sum $files)
* where to put it (e.g. /usr/share/games/doom?)

I've been able to harvest some of this from the Doom wiki.

If you want Hacx or any of the versions of Chex Quest, they'll need
the same data.

Ideally, I would like to rename any shareware wads whose names collide with
non-shareware (e.g. hexen.wad could be either shareware or retail) so
that it is physically possible to install both at the same time.
Doomsday seems to support hexendemo.wad so perhaps that could be its
canonical name in Debian?

I can't support Heretic shareware until I've added a way to spell
"obtain these two files, concatenate them, then unpack them" in the YAML files
that now describe supported games, and Python code to implement that.
But I need that feature at some point anyway, for Quake.

On Mon, 03 Feb 2014 at 11:37:44 +0100, Fabian Greffrath wrote:
> BTW, chocolate-doom supports all three variants of Heretic (shareware, 3
> Ep commercial and 5 Ep retail) but not Hexen demo and Strife demo.

Do we have anything in Debian that can play the Strife demo?
Vavoom from stable maybe? If not, I'm not going to include support for it.

On Wed, 05 Feb 2014 at 13:11:47 +0000, Johey Shmit wrote:
> True for a generic PWAD-target. But wouldn't it make sense to do the hash checking for
> 'official' pwads (hexdd, doom's "no rest for the living" and "Master levels") and
> the shareware versions? These could be placed under the existing 'main' games.

This is the structure I'm using for everything now, with a temporary
historical exception for quake2. Please see data/hexen.yaml for a complete
example (one full game, one expansion, one demo, although the demo is
commented out for now).

The idea is that everything that was sold as a full playable game in its
own right (registered IWADs, in Doom terms) is its own .yaml file and target,
but everything that depends on a particular full game (PWADs), or is a
cut-down demo version of a full game (shareware/demo IWADs), is bundled
into that game's target.

That way, casual players who know they have acquired a game that was sold
as "Foo 3" can point g-d-p at its installation directory (or ideally CD),
tell it foo3, and g-d-p will figure out for itself whether there
are any expansions bundled with it :-)

Regards,
    S