about repacking & installed-size

[Simon McVittie]

On 13/01/15 22:02, Alexandre Detiste wrote:
> Repacking works great & I even get a free mission pack !

That's the patch for Quake III Team Arena. I included it in quake3-data
because its files are part of the Quake 3 binary release that we unpack
to get the patch files, it's tiny compared with pak0.pk3, and that way
we avoid Q3TA owners having to download the patch twice (once to package
Q3A and once more to package Q3TA).

> But I notice a loose dot at the end of "Installed-Size:".
...
> I could have used a split(), but I find doing strip('.') more explicit;
> we could even do "control['Installed-Size'] = int(size)" maybe ?

Debian control files' fields are strings, so it'll just get stringified
again. The split() is the more correct version, I think - it's
equivalent to the "cut -f1" that the shell-script code uses.

> Please pull.

I notice you've rebased my changes onto one of your commits. Did you
mean to rebase your changes onto origin/master instead?

http://git-scm.com/book/en/v2/Git-Branching-Rebasing
http://gitready.com/advanced/2009/02/11/pull-with-rebase.html

> tchet at antec:/usr/local/games/debian/repos$ debdiff quake3-data_*
> -rw-r--r--  root/root   /usr/share/games/quake3-data/baseq3/pak0.pk3
...
> lrwxrwxrwx  root/root   /usr/share/games/quake3/baseq3/pak0.pk3 -> ../../quake3-data/baseq3/pak0.pk3
...
> 
> Files in first .deb but not in second
> -------------------------------------
> -rw-r--r--  root/root   /usr/share/games/quake3/baseq3/pak0.pk3

This is deliberate.

> Installed-Size: [-494296-] {+494864     .+}

That's a bug (now fixed), thanks for spotting it.

    S