Bug#745081: game-data-packager: add support for full versions of wolf3d and spear of destiny

[Stephen Kitt]

On Fri, 16 Jan 2015 00:28:20 +0000, Simon McVittie <smcv at debian.org> wrote:
> On 15/01/15 23:06, Stephen Kitt wrote:
> > On Thu, 15 Jan 2015 10:37:10 +0000, Simon McVittie <smcv at debian.org>
> > wrote:
> >> On Thu, 17 Apr 2014 at 22:37:38 +0200, esp wrote:
> >>>  7) Wolfenstein 3D v1.4 shareware
> >>
> >> Supported for a long time.
> > 
> > It no longer works for me
> 
> Sorry, logic error. A 2-line patch later, it works again.

Indeed, thanks!

> > (BTW, this new default goes against the main help message, which ends with
> > "run game-data-packager [game] to see game-specific arguments".)
> 
> Hmm, yes. I'm not sure what should happen there...
> 
> On one hand, if there's an obvious Easy Correct Thing for
> "game-data-packager $game" to do, it should just go and do it rather
> than expecting extra command-line arguments. It seemed particularly
> silly that for smallish and free-to-download games like Tyrian and the
> Panzer General files for LGeneral, you need to add "-w" to make it
> actually give you a .deb.
> 
> On the other hand, if it goes off and downloads the demo or shareware
> version automatically, the ability to get the full game isn't as
> discoverable as it could be.
> 
> I might go for some sort of compromise, like: if there's suitable
> full-version data in a --search path, just do it; else require some sort
> of hint to the user's intentions before we go off and download things
> (with some standard argument like --auto to mean "do what I mean"). Or
> perhaps I should always require --auto, but allow it to be enabled in a
> configuration file.
> 
> Regardless, the help text should probably say "game-data-packager GAME
> --help" instead.

That all seems perfectly sensible. I definitely like the idea of just doing
the right thing if it's possible by default!

> > I had a look in the Python library but couldn't find any actual use of the
> > optional property. (On g-d-p master.)
> 
> You're quite right. I hadn't actually implemented that feature yet...
> now I have. Hopefully it works.

It works fine now, yes, thanks!

Regards,

Stephen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20150116/7a8a5a5a/attachment.sig>