regression: --demo

[Simon McVittie]

On 21/01/15 16:07, Alexandre Detiste wrote:
> Do you like the "\" ? Some hates it and prefer wrapping the thing in parenthesis.

Your patch looks fine, but as a general rule I prefer parentheses for
line-continuation. Fixed in git (with parentheses).

Looking briefly at your changes on your github, most of them look fine,
but I don't think I like the package.deb thing. If you want to support
Wolf v1.2, I would prefer to go to one extreme or the other - either
give it its own package name and make wolf4sdl depend on 1.2 | 1.4 |
shareware 1.4, or design some way to say "this package contains this
group of files or this group of files, but they all have to match".

I vaguely prefer the separate package name, because a package name is an
"API": anything with a given name and version should be essentially
interchangeable with anything else with that name and version. I'm OK
with having things like licenses and readmes be optional files, because
they aren't the functional part of the package, but I would like game
engines to be able to depend on a given package name guaranteeing a
particular set of functionality.

(Yes I know alternatives sort of break that. In some uses they don't
matter, because the alternatives are functionally identical as far as we
can tell, like the various flavours of Quake 1 mission packs. In others
they do matter, because we can't say whether doom.wad is the 3-episode
retail version or the 4-episode Ultimate Doom, and so on - if we were
able to apply the (free) patches, I'd resolve that by saying "it is
always Ultimate Doom, and we apply enough patches to make that true".)

It would perhaps also be nice to have a "better_version" package
relationship that generalizes demo_for, so that if we find both
Wolfenstein 3D 1.2 and 1.4 for some reason, we can avoid building the
1.2 .deb, and maybe even one day the same for Ultimate Doom and
3-episode Doom. I think demo_for would still be useful information, we
could just make demo_for: B imply better_version: B.

    S