scummvm language auto-detection (was doom3bfg)

Alexandre Detiste alexandre.detiste at gmail.com
Thu Jun 25 21:16:11 UTC 2015


> i've found a small bug in the game language detection 
> script. The loop syntax you used only works in dash, so i think it would 
> be best to either use the standard Bourne syntax or switch the shebang 
> to #!/bin/dash , as not everyone (like me) has set dash as the default 
> shell.

Well, for which game ? Kyrandia 2 and 3 handled dynamicaly by GDP [1]
and/or the DFSG games I have provided a similar patch for. [2,3,4]
(lure of the temptress, drascula, beneath a steel sky)

> as not everyone (like me) has set dash as the default shell.
What did you did ? Do you set a custom shell in /etc/passwd
for your user or symlinked /bin/sh to something else ?

I don't quite understand what I got wrong here,
a patch is welcome.

[1] http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/tree/game_data_packager/games/scummvm_common.py
[2] http://anonscm.debian.org/cgit/pkg-games/lure-of-the-temptress.git/
[3] http://anonscm.debian.org/cgit/pkg-games/drascula.git/
[4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=787943





More information about the Pkg-games-devel mailing list