corsix-th_0.50-1_amd64.changes REJECTED

[Alexandre Detiste]

Le dimanche 28 février 2016, 23:00:21 Luke Faraone a écrit :
> 
> Dear maintainer,
> 
> Unforunately I have to reject your package from NEW.
> 
> CorsixTH-0.50\AnimView\rnc.cpp:
>     Original code was from http://www.yoda.arachsys.com/dk/utils.html, but that
>     site nor the code itself states any ownership or copyright claims.

Hi,

This comment written down by upstream is inaccurate or outdated.

The archive http://www.yoda.arachsys.com/dk/utilsrc.zip
linked from this site _does_ include a LICENSE.TXT
which is word-for-word the "Expat" license as already listed in d/copyright.

I have:
-) documented this in debian/copyright
-) submitted a pull request upstream to have this cleared up for next release


> In addition, how are the various *.map, *.dat, *.pal, *.tab files
> created/edited? Are they generated, or manually edited with some tool?

The tool that generated the .map's file is included in the tarball;
it was excluded from Windows builds because it was broken at 0.50
release time; but I want to enable it for next release.

https://github.com/CorsixTH/CorsixTH/releases says:

"The Map Editor is not included in 0.50 due to incompatibilities with the engine change.
We hope to have a new improved map editor available in a future release.
In the mean time we suggest that level designers copy their full 0.40
install to another location before installing 0.50."

-------

*.dat / *.pal / *.tab were translated from the .bmp files
with the same name in the same directory.

readme.txt says:

"CorsixTH/Bitmap/readme.txt 
Almost all graphics resources are loaded from the original Theme Hospital data
files, which is why there are only a few files in this directory.

build_room_dialog_close.bmp : this sprite is missing from the game's REQ09V.DAT
map_cell_outline.bmp : there is no nice outline tile in the game's VBLK-0.DAT
flag_*.bmp : used as debug overlays
fullscreen_border_*.bmp : used as borders as 640x480 "fullscreen" backgrounds
bootstrap_font.bmp : a homemade bitmap font which can be used for drawing text
                     before the original data files are loaded."


The remaining data (from the original game) are meant to be installed
with game-data-packager.


-----------------------------------

Markus:

I already did the detective work for rnc.cpp and updated the little
things like Vcs-Git, Standard-Version ... but I don't know how to handle
the changelog, especially "(Closes: #610087, #807099)"; 
will this be processed if it remain in 0.50-1 history
while 0.50-2 is added ?

Greets,

Alexandre Detiste
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20160229/a7d29059/attachment.sig>