Bug#831204: mupen64plus-video-glide64: FTBFS with GCC 6: stl_algobase.h:243:56: error: macro "min" passed 3 arguments, but takes just 2

[Lucas Nussbaum]

Source: mupen64plus-video-glide64
Version: 2.0.0+33+g764d9fe-3
Severity: serious
Tags: stretch sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20160713 qa-ftbfs
Justification: FTBFS with GCC 6 on amd64

Hi,

During a rebuild of all packages in sid using the gcc-defaults package
available in experimental to make GCC default to version 6, your package failed
to build on amd64. For more information about GCC 6 and Stretch, see:
- https://wiki.debian.org/GCC6
- https://lists.debian.org/debian-devel-announce/2016/06/msg00007.html

Relevant part (hopefully):
> g++ -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fvisibility-inlines-hidden -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -flto -DNDEBUG -Wall -ffast-math -fno-strict-aliasing -fvisibility=hidden -I../../src -I../../src/wrapper -DGCC -msse -fPIC -I/usr/include/libdrm -I/usr/include/SDL2 -D_REENTRANT "-I/usr/include/mupen64plus/" -g -MD -MP -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64  -c -o _obj/rdp.o ../../src/rdp.cpp
> In file included from /usr/include/c++/6/bits/char_traits.h:39:0,
>                  from /usr/include/c++/6/ios:40,
>                  from /usr/include/c++/6/ostream:38,
>                  from ../../src/Gfx1.3.h:84,
>                  from ../../src/Combine.h:38,
>                  from ../../src/rdp.cpp:46:
> /usr/include/c++/6/bits/stl_algobase.h:243:56: error: macro "min" passed 3 arguments, but takes just 2
>      min(const _Tp& __a, const _Tp& __b, _Compare __comp)
>                                                         ^
> /usr/include/c++/6/bits/stl_algobase.h:265:56: error: macro "max" passed 3 arguments, but takes just 2
>      max(const _Tp& __a, const _Tp& __b, _Compare __comp)
>                                                         ^
> In file included from ../../src/3dmath.h:37:0,
>                  from ../../src/rdp.cpp:43:
> /usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected unqualified-id before 'const'
>      min(const _Tp& __a, const _Tp& __b)
>      ^
> /usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected ')' before 'const'
> /usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected ')' before 'const'
> /usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected initializer before 'const'
> /usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected unqualified-id before 'const'
>      max(const _Tp& __a, const _Tp& __b)
>      ^
> /usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected ')' before 'const'
> /usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected ')' before 'const'
> /usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected initializer before 'const'
> In file included from /usr/include/c++/6/bits/char_traits.h:39:0,
>                  from /usr/include/c++/6/ios:40,
>                  from /usr/include/c++/6/ostream:38,
>                  from ../../src/Gfx1.3.h:84,
>                  from ../../src/Combine.h:38,
>                  from ../../src/rdp.cpp:46:
> /usr/include/c++/6/bits/stl_algobase.h:243:5: error: 'std::min' declared as an 'inline' variable
>      min(const _Tp& __a, const _Tp& __b, _Compare __comp)
>      ^~~
> /usr/include/c++/6/bits/stl_algobase.h:246:7: error: expected primary-expression before 'if'
>        if (__comp(__b, __a))
>        ^~
> /usr/include/c++/6/bits/stl_algobase.h:246:7: error: expected '}' before 'if'
> /usr/include/c++/6/bits/stl_algobase.h:246:7: error: expected ';' before 'if'
> /usr/include/c++/6/bits/stl_algobase.h:248:7: error: expected unqualified-id before 'return'
>        return __a;
>        ^~~~~~
> /usr/include/c++/6/bits/stl_algobase.h:265:5: error: 'max' declared as an 'inline' variable
>      max(const _Tp& __a, const _Tp& __b, _Compare __comp)
>      ^~~
> /usr/include/c++/6/bits/stl_algobase.h:268:7: error: expected primary-expression before 'if'
>        if (__comp(__a, __b))
>        ^~
> /usr/include/c++/6/bits/stl_algobase.h:268:7: error: expected '}' before 'if'
> /usr/include/c++/6/bits/stl_algobase.h:268:7: error: expected ';' before 'if'
> /usr/include/c++/6/bits/stl_algobase.h:270:7: error: expected unqualified-id before 'return'
>        return __a;
>        ^~~~~~
> /usr/include/c++/6/bits/stl_algobase.h:271:5: error: expected declaration before '}' token
>      }
>      ^
> make[2]: *** [_obj/rdp.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2016/07/13/mupen64plus-video-glide64_2.0.0+33+g764d9fe-3_unstable_gcc6.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.