Bug#818128: nethack: please make the build reproducible

[Reiner Herrmann]

On Mon, Mar 14, 2016 at 10:52:22PM +0100, James Cowgill wrote:
> > - makedefs uses the current date/time for the build date that gets
> >   embedded. By using $SOURCE_DATE_EPOCH, the date from the latest
> >   changelog entry is used instead.
> 
> OK, but should this be  tm = gmtime((time_t *) &clocktim);  ?
> ie: drop the call to asctime.
> 
> > +@@ -1281,7 +1284,7 @@
> > +     Fprintf(ofp, "\n");
> > + #ifdef AMIGA
> > +     {
> > +-        struct tm *tm = localtime((time_t *) &clocktim);
> > ++        struct tm *tm = asctime(gmtime((time_t *) &clocktim));
> > +         Fprintf(ofp, "#define AMIGA_VERSION_STRING ");
> > +         Fprintf(ofp, "\"\\0$VER: NetHack %d.%d.%d (%d.%d.%d)\"\n",
> > +                 VERSION_MAJOR, VERSION_MINOR, PATCHLEVEL, tm->tm_mday,

Yes, you are right. This should be only gmtime. :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20160314/25196600/attachment.sig>