Bug#818148: bullet: Out of memory errors do not make the build to stop

[Santiago Vila]

On Tue, Mar 15, 2016 at 02:10:34PM +0100, Markus Koschany wrote:
> > Those are errors that should be caught and the build should have
> > failed, but they are not.
> 
> Why should we make the build fail, if the build log shows that Bullet
> has been built successfully?

Because everything seems to indicate that this is a bug in the Makefile.

An example:

sometarget:
	command1; command2; echo successful

The fact that "make sometarget" says "echo successful" does not mean
every command was executed successfully.

It could be that command1 fails and command2 hides the error. So it
says "sucessfull" improperly.

In this example, the right Makefile should be like this:

sometarget:
	command1 && command2 && echo successful

> Is there anything different with your
> compiled version of Bullet and the current one in Debian's archive?

As I'm only interested in checking that "dpkg-buildpackage -A" works,
I throw the binaries after the build, so I don't know.

But it is easy to imagine that a process that says "out of memory" is
unlikely to produce the correct result.

If a process says "out of memory" and the output is the same,
it means whatever does the process is not used at all.

If you don't mind about the result, why run a command at all?

As I said before, everything seems to indicate that there is an
underlying Makefile bug here. I didn't investigate any further because
there is plenty of evidence ("out of memory" + "successful" build),
that's why I submitted this bug.

Thanks.