Bug#859358: dolphin-emu shouldn't disable PIE

[Adrian Bunk]

Source: dolphin-emu
Version: 5.0+dfsg-1
Severity: normal
Tags: patch

With gcc in stretch defaulting to PIE, hardening=+all,-pie changed
semantics from "enable hardening but not PIE" to "enable all hardening
and explicitely disable the default PIE".
The latter is usually not intended.

The -pie in hardening flags was in some cases required in pre-stretch
releases to avoid build failures caused by (incorrectly) passing -fPIE
to the compiler when building shared libraries or plugins.
This problem does no longer exist.

Please consider applying the following change:

--- debian/rules.old	2017-04-02 18:56:56.000000000 +0000
+++ debian/rules	2017-04-02 18:57:03.000000000 +0000
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 # dolphin does not work with -fPIE
-export DEB_BUILD_MAINT_OPTIONS := hardening=+all,-pie
+export DEB_BUILD_MAINT_OPTIONS := hardening=+all
 export DEB_LDFLAGS_MAINT_APPEND := -Wl,--as-needed
 
 # distributor is used by the opt-in analytics